Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: webrtc/api/datachannel.h

Issue 2235843003: Fix for data channels perpetually stuck in "closing" state. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/datachannel.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 151
152 // The following methods are for SCTP only. 152 // The following methods are for SCTP only.
153 153
154 // Sets the SCTP sid and adds to transport layer if not set yet. Should only 154 // Sets the SCTP sid and adds to transport layer if not set yet. Should only
155 // be called once. 155 // be called once.
156 void SetSctpSid(int sid); 156 void SetSctpSid(int sid);
157 // Called when the transport channel is created. 157 // Called when the transport channel is created.
158 // Only needs to be called for SCTP data channels. 158 // Only needs to be called for SCTP data channels.
159 void OnTransportChannelCreated(); 159 void OnTransportChannelCreated();
160 // Called when the transport channel is destroyed. 160 // Called when the transport channel is destroyed.
161 // This method makes sure the DataChannel is disconnected and changes state
162 // to kClosed.
161 void OnTransportChannelDestroyed(); 163 void OnTransportChannelDestroyed();
162 164
163 // The following methods are for RTP only. 165 // The following methods are for RTP only.
164 166
165 // Set the SSRC this channel should use to send data on the 167 // Set the SSRC this channel should use to send data on the
166 // underlying data engine. |send_ssrc| == 0 means that the channel is no 168 // underlying data engine. |send_ssrc| == 0 means that the channel is no
167 // longer part of the session negotiation. 169 // longer part of the session negotiation.
168 void SetSendSsrc(uint32_t send_ssrc); 170 void SetSendSsrc(uint32_t send_ssrc);
169 // Set the SSRC this channel should use to receive data from the 171 // Set the SSRC this channel should use to receive data from the
170 // underlying data engine. 172 // underlying data engine.
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 PROXY_CONSTMETHOD0(int, id) 275 PROXY_CONSTMETHOD0(int, id)
274 PROXY_CONSTMETHOD0(DataState, state) 276 PROXY_CONSTMETHOD0(DataState, state)
275 PROXY_CONSTMETHOD0(uint64_t, buffered_amount) 277 PROXY_CONSTMETHOD0(uint64_t, buffered_amount)
276 PROXY_METHOD0(void, Close) 278 PROXY_METHOD0(void, Close)
277 PROXY_METHOD1(bool, Send, const DataBuffer&) 279 PROXY_METHOD1(bool, Send, const DataBuffer&)
278 END_SIGNALING_PROXY() 280 END_SIGNALING_PROXY()
279 281
280 } // namespace webrtc 282 } // namespace webrtc
281 283
282 #endif // WEBRTC_API_DATACHANNEL_H_ 284 #endif // WEBRTC_API_DATACHANNEL_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/datachannel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698