Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2235833002: MB: Add Windows configurations (Closed)

Created:
4 years, 4 months ago by kjellander_webrtc
Modified:
4 years, 4 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Add Windows configurations BUG=589510, 636414 NOTRY=True Committed: https://crrev.com/0ae7878bbc7a9cb437e795125d81b92ef5d7a726 Cr-Commit-Position: refs/heads/master@{#13721}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -1 line) Patch
M webrtc/build/mb_config.pyl View 1 7 chunks +75 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
kjellander_webrtc
4 years, 4 months ago (2016-08-10 16:16:09 UTC) #3
ehmaldonado_webrtc
I think you should rebase this.
4 years, 4 months ago (2016-08-11 07:11:56 UTC) #4
kjellander_webrtc
On 2016/08/11 07:11:56, ehmaldonado_webrtc wrote: > I think you should rebase this. Done.
4 years, 4 months ago (2016-08-11 07:14:56 UTC) #5
ehmaldonado_webrtc
On 2016/08/11 07:14:56, kjellander_webrtc wrote: > On 2016/08/11 07:11:56, ehmaldonado_webrtc wrote: > > I think ...
4 years, 4 months ago (2016-08-11 07:15:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2235833002/20001
4 years, 4 months ago (2016-08-11 07:31:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 07:49:53 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 07:50:01 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ae7878bbc7a9cb437e795125d81b92ef5d7a726
Cr-Commit-Position: refs/heads/master@{#13721}

Powered by Google App Engine
This is Rietveld 408576698