Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: webrtc/modules/pacing/bitrate_prober_unittest.cc

Issue 2235373004: Probing: Add support for exponential startup probing (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@fix_probing2
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/pacing/bitrate_prober_unittest.cc
diff --git a/webrtc/modules/pacing/bitrate_prober_unittest.cc b/webrtc/modules/pacing/bitrate_prober_unittest.cc
index 422bd27b686f38d466c3a8936caf65990d5a7004..2699f3b59c1f9c87b287b840c992e853cc189486 100644
--- a/webrtc/modules/pacing/bitrate_prober_unittest.cc
+++ b/webrtc/modules/pacing/bitrate_prober_unittest.cc
@@ -25,7 +25,7 @@ TEST(BitrateProberTest, VerifyStatesAndTimeBetweenProbes) {
prober.CreateProbeCluster(1800000, 5);
EXPECT_FALSE(prober.IsProbing());
- prober.OnIncomingPacket(1000);
+ prober.OnIncomingPacket(now_ms, 1000);
EXPECT_TRUE(prober.IsProbing());
EXPECT_EQ(0, prober.CurrentClusterId());
@@ -63,7 +63,7 @@ TEST(BitrateProberTest, DoesntProbeWithoutRecentPackets) {
prober.CreateProbeCluster(900000, 6);
EXPECT_FALSE(prober.IsProbing());
- prober.OnIncomingPacket(1000);
+ prober.OnIncomingPacket(now_ms, 1000);
EXPECT_TRUE(prober.IsProbing());
EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms));
prober.PacketSent(now_ms, 1000);
@@ -71,25 +71,25 @@ TEST(BitrateProberTest, DoesntProbeWithoutRecentPackets) {
now_ms += 6000;
EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
// Insert a small packet, not a candidate for probing.
- prober.OnIncomingPacket(100);
+ prober.OnIncomingPacket(now_ms, 100);
prober.PacketSent(now_ms, 100);
EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
// Insert a large-enough packet after downtime while probing should reset to
// perform a new probe since the requested one didn't finish.
- prober.OnIncomingPacket(1000);
+ prober.OnIncomingPacket(now_ms, 1000);
EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms));
prober.PacketSent(now_ms, 1000);
// Next packet should be part of new probe and be sent with non-zero delay.
- prober.OnIncomingPacket(1000);
+ prober.OnIncomingPacket(now_ms, 1000);
EXPECT_GT(prober.TimeUntilNextProbe(now_ms), 0);
}
TEST(BitrateProberTest, DoesntInitializeProbingForSmallPackets) {
BitrateProber prober;
- prober.SetEnabled(true);
EXPECT_FALSE(prober.IsProbing());
- prober.OnIncomingPacket(100);
+ int64_t now_ms = 0;
+ prober.OnIncomingPacket(now_ms, 100);
EXPECT_FALSE(prober.IsProbing());
}

Powered by Google App Engine
This is Rietveld 408576698