Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: webrtc/call/bitrate_estimator_tests.cc

Issue 2234363002: Removed old probe cluster logic and logic related to ssrcs from DelayBasedBwe. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added comment for kFixedSsrc. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/delay_based_bwe.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <functional> 10 #include <functional>
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 262
263 static const char* kAbsSendTimeLog = 263 static const char* kAbsSendTimeLog =
264 "RemoteBitrateEstimatorAbsSendTime: Instantiating."; 264 "RemoteBitrateEstimatorAbsSendTime: Instantiating.";
265 static const char* kSingleStreamLog = 265 static const char* kSingleStreamLog =
266 "RemoteBitrateEstimatorSingleStream: Instantiating."; 266 "RemoteBitrateEstimatorSingleStream: Instantiating.";
267 267
268 TEST_F(BitrateEstimatorTest, InstantiatesTOFPerDefaultForVideo) { 268 TEST_F(BitrateEstimatorTest, InstantiatesTOFPerDefaultForVideo) {
269 video_send_config_.rtp.extensions.push_back( 269 video_send_config_.rtp.extensions.push_back(
270 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOFExtensionId)); 270 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOFExtensionId));
271 receiver_log_.PushExpectedLogLine(kSingleStreamLog); 271 receiver_log_.PushExpectedLogLine(kSingleStreamLog);
272 receiver_log_.PushExpectedLogLine(kAbsSendTimeLog);
273 receiver_log_.PushExpectedLogLine(kSingleStreamLog); 272 receiver_log_.PushExpectedLogLine(kSingleStreamLog);
274 streams_.push_back(new Stream(this, false)); 273 streams_.push_back(new Stream(this, false));
275 EXPECT_TRUE(receiver_log_.Wait()); 274 EXPECT_TRUE(receiver_log_.Wait());
276 } 275 }
277 276
278 TEST_F(BitrateEstimatorTest, ImmediatelySwitchToASTForVideo) { 277 TEST_F(BitrateEstimatorTest, ImmediatelySwitchToASTForVideo) {
279 video_send_config_.rtp.extensions.push_back( 278 video_send_config_.rtp.extensions.push_back(
280 RtpExtension(RtpExtension::kAbsSendTimeUri, kASTExtensionId)); 279 RtpExtension(RtpExtension::kAbsSendTimeUri, kASTExtensionId));
281 receiver_log_.PushExpectedLogLine(kSingleStreamLog); 280 receiver_log_.PushExpectedLogLine(kSingleStreamLog);
282 receiver_log_.PushExpectedLogLine(kAbsSendTimeLog);
283 receiver_log_.PushExpectedLogLine(kSingleStreamLog); 281 receiver_log_.PushExpectedLogLine(kSingleStreamLog);
284 receiver_log_.PushExpectedLogLine(kAbsSendTimeLog);
285 receiver_log_.PushExpectedLogLine("Switching to absolute send time RBE."); 282 receiver_log_.PushExpectedLogLine("Switching to absolute send time RBE.");
stefan-webrtc 2016/08/11 15:38:59 I'm surprised that this doesn't require an abs sen
philipel 2016/08/12 08:31:02 Line 282 and 284 has now been replaced by the Dela
286 streams_.push_back(new Stream(this, false)); 283 streams_.push_back(new Stream(this, false));
287 EXPECT_TRUE(receiver_log_.Wait()); 284 EXPECT_TRUE(receiver_log_.Wait());
288 } 285 }
289 286
290 TEST_F(BitrateEstimatorTest, SwitchesToASTForVideo) { 287 TEST_F(BitrateEstimatorTest, SwitchesToASTForVideo) {
291 video_send_config_.rtp.extensions.push_back( 288 video_send_config_.rtp.extensions.push_back(
292 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOFExtensionId)); 289 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOFExtensionId));
293 receiver_log_.PushExpectedLogLine(kSingleStreamLog); 290 receiver_log_.PushExpectedLogLine(kSingleStreamLog);
294 receiver_log_.PushExpectedLogLine(kAbsSendTimeLog);
295 receiver_log_.PushExpectedLogLine(kSingleStreamLog); 291 receiver_log_.PushExpectedLogLine(kSingleStreamLog);
296 streams_.push_back(new Stream(this, false)); 292 streams_.push_back(new Stream(this, false));
297 EXPECT_TRUE(receiver_log_.Wait()); 293 EXPECT_TRUE(receiver_log_.Wait());
298 294
299 video_send_config_.rtp.extensions[0] = 295 video_send_config_.rtp.extensions[0] =
300 RtpExtension(RtpExtension::kAbsSendTimeUri, kASTExtensionId); 296 RtpExtension(RtpExtension::kAbsSendTimeUri, kASTExtensionId);
301 receiver_log_.PushExpectedLogLine(kAbsSendTimeLog);
302 receiver_log_.PushExpectedLogLine("Switching to absolute send time RBE."); 297 receiver_log_.PushExpectedLogLine("Switching to absolute send time RBE.");
303 streams_.push_back(new Stream(this, false)); 298 streams_.push_back(new Stream(this, false));
304 EXPECT_TRUE(receiver_log_.Wait()); 299 EXPECT_TRUE(receiver_log_.Wait());
305 } 300 }
306 301
307 // This test is flaky. See webrtc:5790. 302 // This test is flaky. See webrtc:5790.
308 TEST_F(BitrateEstimatorTest, DISABLED_SwitchesToASTThenBackToTOFForVideo) { 303 TEST_F(BitrateEstimatorTest, DISABLED_SwitchesToASTThenBackToTOFForVideo) {
309 video_send_config_.rtp.extensions.push_back( 304 video_send_config_.rtp.extensions.push_back(
310 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOFExtensionId)); 305 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOFExtensionId));
311 receiver_log_.PushExpectedLogLine(kSingleStreamLog); 306 receiver_log_.PushExpectedLogLine(kSingleStreamLog);
(...skipping 13 matching lines...) Expand all
325 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOFExtensionId); 320 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOFExtensionId);
326 receiver_log_.PushExpectedLogLine(kAbsSendTimeLog); 321 receiver_log_.PushExpectedLogLine(kAbsSendTimeLog);
327 receiver_log_.PushExpectedLogLine( 322 receiver_log_.PushExpectedLogLine(
328 "WrappingBitrateEstimator: Switching to transmission time offset RBE."); 323 "WrappingBitrateEstimator: Switching to transmission time offset RBE.");
329 streams_.push_back(new Stream(this, false)); 324 streams_.push_back(new Stream(this, false));
330 streams_[0]->StopSending(); 325 streams_[0]->StopSending();
331 streams_[1]->StopSending(); 326 streams_[1]->StopSending();
332 EXPECT_TRUE(receiver_log_.Wait()); 327 EXPECT_TRUE(receiver_log_.Wait());
333 } 328 }
334 } // namespace webrtc 329 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/delay_based_bwe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698