|
|
Chromium Code Reviews
DescriptionGN: Add dependency libjingle_peerconnection_java to modules_unittests.
This change only affects the Android build.
BUG=webrtc:6189
TBR=tommi@webrtc.org
NOTRY=True
Committed: https://crrev.com/bd59c71ff8d7014aee8fb64fa965b01e3b59671b
Cr-Commit-Position: refs/heads/master@{#13722}
Patch Set 1 #
Messages
Total messages: 30 (19 generated)
The CQ bit was checked by sakal@webrtc.org
The CQ bit was unchecked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 ========== to ========== Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 ==========
sakal@webrtc.org changed reviewers: + kjellander@google.com
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
PTAL
PTAL
sakal@webrtc.org changed reviewers: + kjellander@webrtc.org - kjellander@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_dbg/builds/1713) ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_rel/builds/1735) ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/9434) ios_api_framework on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...) ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/11749) ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/11681) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/16991) ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/15641)
Accidentally chose wrong reviewer, sorry about that. PTAL.
Description was changed from ========== Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 ========== to ========== GN: Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 ==========
lgtm, you can set NOTRY=True and ignore the failing iOS bots (infra problem). I'm fixing the android_arm64_rel trybot in https://codereview.webrtc.org/2233913002/
Description was changed from ========== GN: Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 ========== to ========== GN: Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 NOTRY=True ==========
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7356)
Description was changed from ========== GN: Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 NOTRY=True ========== to ========== GN: Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 TBR=tommi@webrtc.org NOTRY=True ==========
sakal@webrtc.org changed reviewers: + tommi@webrtc.org
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== GN: Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 TBR=tommi@webrtc.org NOTRY=True ========== to ========== GN: Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 TBR=tommi@webrtc.org NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== GN: Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 TBR=tommi@webrtc.org NOTRY=True ========== to ========== GN: Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 TBR=tommi@webrtc.org NOTRY=True Committed: https://crrev.com/bd59c71ff8d7014aee8fb64fa965b01e3b59671b Cr-Commit-Position: refs/heads/master@{#13722} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bd59c71ff8d7014aee8fb64fa965b01e3b59671b Cr-Commit-Position: refs/heads/master@{#13722} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
