Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 2233903002: GN: Add dependency libjingle_peerconnection_java to modules_unittests. (Closed)

Created:
4 years, 4 months ago by sakal
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, Max Morin WebRTC
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Add dependency libjingle_peerconnection_java to modules_unittests. This change only affects the Android build. BUG=webrtc:6189 TBR=tommi@webrtc.org NOTRY=True Committed: https://crrev.com/bd59c71ff8d7014aee8fb64fa965b01e3b59671b Cr-Commit-Position: refs/heads/master@{#13722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/modules/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 30 (19 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2233903002/1
4 years, 4 months ago (2016-08-10 14:46:44 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-10 14:46:46 UTC) #5
sakal
PTAL
4 years, 4 months ago (2016-08-10 14:48:08 UTC) #10
sakal
PTAL
4 years, 4 months ago (2016-08-10 14:48:09 UTC) #11
sakal
Accidentally chose wrong reviewer, sorry about that. PTAL.
4 years, 4 months ago (2016-08-10 14:49:10 UTC) #15
kjellander_webrtc
lgtm, you can set NOTRY=True and ignore the failing iOS bots (infra problem). I'm fixing ...
4 years, 4 months ago (2016-08-10 15:20:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2233903002/1
4 years, 4 months ago (2016-08-11 07:34:33 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7356)
4 years, 4 months ago (2016-08-11 07:52:22 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2233903002/1
4 years, 4 months ago (2016-08-11 07:58:02 UTC) #26
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 07:59:19 UTC) #28
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 07:59:31 UTC) #30
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd59c71ff8d7014aee8fb64fa965b01e3b59671b
Cr-Commit-Position: refs/heads/master@{#13722}

Powered by Google App Engine
This is Rietveld 408576698