Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2233843002: Fix tools_unittests in GN. (Closed)

Created:
4 years, 4 months ago by ehmaldonado_webrtc
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix tools_unittests in GN. tools_unittests were failing when generated by GN and running on a device. BUG=webrtc:5949 NOTRY=True Committed: https://crrev.com/4556b450765116072f9700e0619c86b0f9b06588 Cr-Commit-Position: refs/heads/master@{#13714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/tools/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ehmaldonado_webrtc
This makes the tests run. I'm curious why there is not something similar in GYP, ...
4 years, 4 months ago (2016-08-10 13:34:36 UTC) #3
kjellander_webrtc
On 2016/08/10 13:34:36, ehmaldonado_webrtc wrote: > This makes the tests run. > I'm curious why ...
4 years, 4 months ago (2016-08-10 14:36:29 UTC) #4
kjellander_webrtc
lgtm (please add NOTRY=True to save some time for this tiny GN-only change)
4 years, 4 months ago (2016-08-10 14:37:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2233843002/1
4 years, 4 months ago (2016-08-10 14:46:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 14:47:18 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 14:47:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4556b450765116072f9700e0619c86b0f9b06588
Cr-Commit-Position: refs/heads/master@{#13714}

Powered by Google App Engine
This is Rietveld 408576698