Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2233793002: Add magjed@webrtc.org as owner of webrtc/base/java/ (Closed)

Created:
4 years, 4 months ago by magjed_webrtc
Modified:
4 years, 4 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add magjed@webrtc.org as owner of webrtc/base/java/ magjed@ is the author of two out of three files in webrtc/base/java (ThreadUtils.java and Size.java). They were originally created in webrtc/api/android/java, but were moved to base/ in order to be accessible from e.g. webrtc/modules/audio_device/android/java. TBR=tommi@webrtc.org Committed: https://crrev.com/6e6e70f55bde261d91b6454cd0e56e24562c084d Cr-Commit-Position: refs/heads/master@{#13707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + webrtc/base/java/src/org/webrtc/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
magjed_webrtc
tommi - Please take a look when you have time. I'm TBR:ing to unblock an ...
4 years, 4 months ago (2016-08-10 11:49:05 UTC) #4
magjed_webrtc
Committed patchset #1 (id:1) manually as 6e6e70f55bde261d91b6454cd0e56e24562c084d (presubmit successful).
4 years, 4 months ago (2016-08-10 11:49:40 UTC) #6
tommi
4 years, 4 months ago (2016-08-10 12:27:51 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698