Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: webrtc/api/test/mockpeerconnectionobservers.h

Issue 2233033002: Adding test for unordered, fragmented SCTP message delivery. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix the setting of the SCTP MTU. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/test/mockpeerconnectionobservers.h
diff --git a/webrtc/api/test/mockpeerconnectionobservers.h b/webrtc/api/test/mockpeerconnectionobservers.h
index 39a8f0134d63f42d82390cc9840e98e7734024b7..23647f6de3b5cbf3d5c8e6fda845103c77a04441 100644
--- a/webrtc/api/test/mockpeerconnectionobservers.h
+++ b/webrtc/api/test/mockpeerconnectionobservers.h
@@ -74,7 +74,7 @@ class MockSetSessionDescriptionObserver
class MockDataChannelObserver : public webrtc::DataChannelObserver {
public:
explicit MockDataChannelObserver(webrtc::DataChannelInterface* channel)
- : channel_(channel), received_message_count_(0) {
+ : channel_(channel) {
channel_->RegisterObserver(this);
state_ = channel_->state();
}
@@ -86,19 +86,21 @@ class MockDataChannelObserver : public webrtc::DataChannelObserver {
void OnStateChange() override { state_ = channel_->state(); }
void OnMessage(const DataBuffer& buffer) override {
- last_message_.assign(buffer.data.data<char>(), buffer.data.size());
- ++received_message_count_;
+ messages_.push_back(
+ std::string(buffer.data.data<char>(), buffer.data.size()));
}
bool IsOpen() const { return state_ == DataChannelInterface::kOpen; }
- const std::string& last_message() const { return last_message_; }
- size_t received_message_count() const { return received_message_count_; }
+ std::vector<std::string> messages() const { return messages_; }
+ std::string last_message() const {
+ return messages_.empty() ? std::string() : messages_.back();
+ }
+ size_t received_message_count() const { return messages_.size(); }
private:
rtc::scoped_refptr<webrtc::DataChannelInterface> channel_;
DataChannelInterface::DataState state_;
- std::string last_message_;
- size_t received_message_count_;
+ std::vector<std::string> messages_;
};
class MockStatsObserver : public webrtc::StatsObserver {

Powered by Google App Engine
This is Rietveld 408576698