Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: webrtc/modules/audio_mixer/new_audio_conference_mixer.h

Issue 2230823004: Added a level indicator to new mixer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@mixer_gn_fixes
Patch Set: Updated comments in volume test. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_mixer/new_audio_conference_mixer.h
diff --git a/webrtc/modules/audio_mixer/new_audio_conference_mixer.h b/webrtc/modules/audio_mixer/new_audio_conference_mixer.h
index 561cf88604f58cf51ee4352f10e8e7df0bd6f1e2..55c17eda1195728ab6695ce8eed5be2dfd5204f2 100644
--- a/webrtc/modules/audio_mixer/new_audio_conference_mixer.h
+++ b/webrtc/modules/audio_mixer/new_audio_conference_mixer.h
@@ -59,6 +59,11 @@ class NewAudioConferenceMixer {
virtual bool AnonymousMixabilityStatus(
const MixerAudioSource& audio_source) const = 0;
+ // Output level functions from VoEVolumeControl
minyue-webrtc 2016/08/11 10:27:33 would be good to note the unit of level somewhere,
aleloi 2016/08/11 12:15:19 Thank you! Updated documentation in next patch set
+ virtual uint32_t GetSpeechOutputLevel() = 0;
+
+ virtual uint32_t GetSpeechOutputLevelFullRange() = 0;
+
protected:
NewAudioConferenceMixer() {}
};

Powered by Google App Engine
This is Rietveld 408576698