Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2229473002: GN target for test_packet_masks_metrics. (Closed)

Created:
4 years, 4 months ago by brandtr
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN target for test_packet_masks_metrics. NOTRY=True BUG=webrtc:6193 Committed: https://crrev.com/03bc3cfb3eba305dc45615bb98c2a1a1e1768607 Cr-Commit-Position: refs/heads/master@{#13672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
brandtr
Hey kjellander, please have a look at my attempt to create a GN target for ...
4 years, 4 months ago (2016-08-08 14:20:09 UTC) #2
kjellander_webrtc
lgtm, this looks like the right location for me. Make sure you add NOTRY=True to ...
4 years, 4 months ago (2016-08-08 14:51:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2229473002/1
4 years, 4 months ago (2016-08-08 15:05:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 15:08:57 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 15:09:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03bc3cfb3eba305dc45615bb98c2a1a1e1768607
Cr-Commit-Position: refs/heads/master@{#13672}

Powered by Google App Engine
This is Rietveld 408576698