Skip unit test if GYP_DEFINES="rtc_use_h264=1" is not set.

Skip unit test if GYP_DEFINES="rtc_use_h264=1" is not set.

Unit test would fail in default configuration (e.g. rtc_use_h264=0), cause it tests instantiating H264 specifics.

BUG=webrtc:6194, webrtc:6198
Committed: https://crrev.com/073ece45b68fc1aecb88692438bcb762e9fd18d5
Cr-Commit-Position: refs/heads/master@{#13929}

[johan, 2016-08-09 07:50:57]

johan@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[johan, 2016-08-09 08:42:17]

Update: no review needed right now. Patch Set 1 will not work if rtc_use_h264=1
is set, as define WEBRTC_USE_H264 will be set only in
./modules/video_coding/codecs/h264/h264.gypi:29 which does not affect
webrtc/media/engine/webrtcvideoengine2_unittest.cc .

[johan, 2016-08-09 13:22:19]

The CQ bit was checked by johan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 13:22:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[johan, 2016-08-09 13:42:24]

mflodman, please have a look

[commit-bot: I haz the power, 2016-08-09 15:22:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 15:23:00]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[johan, 2016-08-10 13:36:13]

Description was changed from

==========
Skip unit test if GYP_DEFINES="rtc_use_h264=1" is not set.

BUG=webrtc:6194
==========

to

==========
Skip unit test if GYP_DEFINES="rtc_use_h264=1" is not set.

BUG=webrtc:6194, webrtc:6198
==========

[johan, 2016-08-24 08:39:56]

Description was changed from

==========
Skip unit test if GYP_DEFINES="rtc_use_h264=1" is not set.

BUG=webrtc:6194, webrtc:6198
==========

to

==========
Skip unit test if GYP_DEFINES="rtc_use_h264=1" is not set.

Unit test would fail in default configuration (e.g. rtc_use_h264=0), cause it
tests instantiating H264 specifics.

BUG=webrtc:6194, webrtc:6198
==========

[johan, 2016-08-24 08:40:15]

On 2016/08/09 13:42:24, johan wrote:
> mflodman, please have a look

ping

[sprang_webrtc, 2016-08-25 11:19:12]

sprang@webrtc.org changed reviewers:
+ magjed@webrtc.org, sprang@webrtc.org
- mflodman@webrtc.org

[sprang_webrtc, 2016-08-25 11:19:12]

-mflodman +magjed
magjed ptal, you probably have more time for reviews than mflodman right now?

[magjed_webrtc, 2016-08-25 14:01:44]

lgtm

[johan, 2016-08-25 14:15:16]

The CQ bit was checked by johan@webrtc.org

[commit-bot: I haz the power, 2016-08-25 14:15:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-25 16:15:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 16:15:47]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[johan, 2016-08-25 16:35:24]

The CQ bit was checked by johan@webrtc.org

[commit-bot: I haz the power, 2016-08-25 16:35:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-25 17:51:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 17:51:52]

Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15836)

[johan, 2016-08-26 09:13:35]

The CQ bit was checked by johan@webrtc.org

[commit-bot: I haz the power, 2016-08-26 09:13:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-26 09:59:51]

Description was changed from

==========
Skip unit test if GYP_DEFINES="rtc_use_h264=1" is not set.

Unit test would fail in default configuration (e.g. rtc_use_h264=0), cause it
tests instantiating H264 specifics.

BUG=webrtc:6194, webrtc:6198
==========

to

==========
Skip unit test if GYP_DEFINES="rtc_use_h264=1" is not set.

Unit test would fail in default configuration (e.g. rtc_use_h264=0), cause it
tests instantiating H264 specifics.

BUG=webrtc:6194, webrtc:6198
==========

[commit-bot: I haz the power, 2016-08-26 09:59:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-26 10:00:02]

Description was changed from

==========
Skip unit test if GYP_DEFINES="rtc_use_h264=1" is not set.

Unit test would fail in default configuration (e.g. rtc_use_h264=0), cause it
tests instantiating H264 specifics.

BUG=webrtc:6194, webrtc:6198
==========

to

==========
Skip unit test if GYP_DEFINES="rtc_use_h264=1" is not set.

Unit test would fail in default configuration (e.g. rtc_use_h264=0), cause it
tests instantiating H264 specifics.

BUG=webrtc:6194, webrtc:6198

Committed: https://crrev.com/073ece45b68fc1aecb88692438bcb762e9fd18d5
Cr-Commit-Position: refs/heads/master@{#13929}
==========

[commit-bot: I haz the power, 2016-08-26 10:00:03]

Patchset 2 (id:??) landed as
https://crrev.com/073ece45b68fc1aecb88692438bcb762e9fd18d5
Cr-Commit-Position: refs/heads/master@{#13929}

[kjellander_webrtc, 2016-08-26 10:30:16]

On 2016/08/26 10:00:03, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/073ece45b68fc1aecb88692438bcb762e9fd18d5
> Cr-Commit-Position: refs/heads/master@{#13929}

Sorry about this, we've been wanting to setup a bot
(https://bugs.chromium.org/p/chromium/issues/detail?id=606944) for this config
but it's been slipping due to higher prio tasks.