Issue 2228683002: Adjust H264 QP thresholds.

Issue 2228683002: Adjust H264 QP thresholds. (Closed)

Created:
4 years, 4 months ago by tkchin_webrtc

Modified:
4 years, 4 months ago

Reviewers:
pbos-webrtc, mflodman

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman, juberti1

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Adjust H264 QP thresholds. NOTRY=True BUG= Committed: https://crrev.com/6a450105cdc199380128c6dd6567587f1a0dc09b Cr-Commit-Position: refs/heads/master@{#13680}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	webrtc/modules/video_coding/utility/quality_scaler.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 12 (6 generated)

tkchin_webrtc

Needs to be tuned further. However, with this we will stay VGA at ~450kbps.

4 years, 4 months ago (2016-08-08 21:35:57 UTC) #3

pbos-webrtc

rs-lgtm, but I would like Stockholm to verify these thresholds.

4 years, 4 months ago (2016-08-08 21:50:15 UTC) #4

tkchin_webrtc

On 2016/08/08 21:50:15, pbos-webrtc wrote: > rs-lgtm, but I would like Stockholm to verify these ...

4 years, 4 months ago (2016-08-08 22:26:12 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2228683002/1

4 years, 4 months ago (2016-08-08 22:26:23 UTC) #8

commit-bot: I haz the power

4 years, 4 months ago (2016-08-08 22:27:47 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6a450105cdc199380128c6dd6567587f1a0dc09b
Cr-Commit-Position: refs/heads/master@{#13680}