Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Issue 2228503003: Added new mixer folder to CPPLINT_DIRS. Fixed one small issue. (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@change_mixer_mix
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added new mixer folder to CPPLINT_DIRS. Fixed one small issue. NOTRY=True Committed: https://crrev.com/df9e4d9fce7c0477299bdafb22aad59715f591e3 Cr-Commit-Position: refs/heads/master@{#13677}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h View 1 chunk +1 line, -0 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 16 (8 generated)
aleloi
I think the new mixer module folder should be added to CPPLINT_DIRS. https://codereview.webrtc.org/2228503003/diff/1/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h File webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h ...
4 years, 4 months ago (2016-08-08 14:21:34 UTC) #1
aleloi
I think the new mixer module folder should be added to CPPLINT_DIRS.
4 years, 4 months ago (2016-08-08 14:22:31 UTC) #3
kjellander_webrtc
Nice to see new paths being added to lint checking. Make sure to set NOTRY=True ...
4 years, 4 months ago (2016-08-08 14:49:04 UTC) #4
kjellander_webrtc
... and lgtm
4 years, 4 months ago (2016-08-08 14:49:17 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2221443002 Patch 100001). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-08 14:49:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2228503003/1
4 years, 4 months ago (2016-08-08 17:23:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 17:26:12 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 17:26:21 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df9e4d9fce7c0477299bdafb22aad59715f591e3
Cr-Commit-Position: refs/heads/master@{#13677}

Powered by Google App Engine
This is Rietveld 408576698