Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2227733004: Add an HD resolution perf test. (Closed)

Created:
4 years, 4 months ago by stefan-webrtc
Modified:
4 years, 4 months ago
Reviewers:
sprang_webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add an HD resolution perf test. Also update existing perf tests to use send side bwe. BUG=webrtc:4604, chromium:522001 Committed: https://crrev.com/b17976763d58e9fdf5b25747ec45f86344225627 Cr-Commit-Position: refs/heads/master@{#13726}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : Add a new test which still runs with recv-side bwe. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -36 lines) Patch
A resources/ConferenceMotion_1280_720_50.yuv.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/full_stack.cc View 1 2 3 11 chunks +46 lines, -19 lines 0 comments Download
M webrtc/video/screenshare_loopback.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/video_loopback.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M webrtc/video/video_quality_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 2 3 4 chunks +19 lines, -6 lines 0 comments Download
M webrtc/webrtc_perf_tests.isolate View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
stefan-webrtc
4 years, 4 months ago (2016-08-09 13:54:17 UTC) #2
sprang_webrtc
lgtm
4 years, 4 months ago (2016-08-09 14:19:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2227733004/20001
4 years, 4 months ago (2016-08-09 14:23:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7294)
4 years, 4 months ago (2016-08-09 14:44:22 UTC) #9
stefan-webrtc
4 years, 4 months ago (2016-08-10 08:57:24 UTC) #11
stefan-webrtc
Magnus, could you approve the change to webrtc_perf_tests.isolate?
4 years, 4 months ago (2016-08-10 08:57:45 UTC) #12
sprang_webrtc
https://codereview.webrtc.org/2227733004/diff/40001/webrtc/video/video_quality_test.cc File webrtc/video/video_quality_test.cc (right): https://codereview.webrtc.org/2227733004/diff/40001/webrtc/video/video_quality_test.cc#newcode417 webrtc/video/video_quality_test.cc:417: } else { reference_copy.set_ntp_time_ms(reference.ntp_time_ms()); render_copy.set_ntp_time_ms(render.ntp_time_ms()); } Otherwise some time ...
4 years, 4 months ago (2016-08-11 10:43:50 UTC) #13
stefan-webrtc
Add a new test which still runs with recv-side bwe.
4 years, 4 months ago (2016-08-11 10:49:23 UTC) #14
stefan-webrtc
PTAL https://codereview.webrtc.org/2227733004/diff/40001/webrtc/video/video_quality_test.cc File webrtc/video/video_quality_test.cc (right): https://codereview.webrtc.org/2227733004/diff/40001/webrtc/video/video_quality_test.cc#newcode417 webrtc/video/video_quality_test.cc:417: } On 2016/08/11 10:43:50, språng wrote: > else ...
4 years, 4 months ago (2016-08-11 10:49:47 UTC) #15
mflodman
isolate LGTM
4 years, 4 months ago (2016-08-11 11:29:14 UTC) #16
sprang_webrtc
lgtm
4 years, 4 months ago (2016-08-11 11:32:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2227733004/60001
4 years, 4 months ago (2016-08-11 11:33:08 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-11 14:01:00 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 14:01:11 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b17976763d58e9fdf5b25747ec45f86344225627
Cr-Commit-Position: refs/heads/master@{#13726}

Powered by Google App Engine
This is Rietveld 408576698