Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2227633002: Minor cosmetic improvements to the new mixer. (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
Reviewers:
aleloi2, minyue-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@change_mixer_mix
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Renamed old-style variables. Committed: https://crrev.com/6382a19dc462c7b94c5b442f83b8910f9f4a43a1 Cr-Commit-Position: refs/heads/master@{#13676}

Patch Set 1 : Renamed old-style variables in mixer. #

Patch Set 2 : Removed loops in favor of std::find. #

Patch Set 3 : Fixed 'uninitialized' error in upstream. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -79 lines) Patch
M webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h View 3 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.cc View 1 2 19 chunks +66 lines, -71 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (13 generated)
aleloi
Mini-change. Renamed vars and replaced for-loops with std::find. Please take a look!
4 years, 4 months ago (2016-08-08 11:34:16 UTC) #3
minyue-webrtc
lgtm
4 years, 4 months ago (2016-08-08 13:56:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2227633002/40001
4 years, 4 months ago (2016-08-08 17:23:27 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-08 17:25:07 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 17:25:18 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6382a19dc462c7b94c5b442f83b8910f9f4a43a1
Cr-Commit-Position: refs/heads/master@{#13676}

Powered by Google App Engine
This is Rietveld 408576698