Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2226933005:
remove unnecessary double allocation (Closed)
|
Created:
4 years, 4 months ago by kthelgason Modified:
4 years, 4 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
Descriptionremove unnecessary double allocation
BUG=
Committed: https://crrev.com/3e3ebe6937f2593d864566148329b658b6fa52dc
Cr-Commit-Position: refs/heads/master@{#13744}
Patch Set 1 #
Messages
Total messages: 31 (18 generated)
kthelgason@webrtc.org changed reviewers: + magjed@webrtc.org
Tiny change for you to take a look at!
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
The CQ bit was unchecked by kthelgason@webrtc.org
The CQ bit was checked by kthelgason@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Nice! lgtm I'm not an owner of this file yet, so you have to add tkchin@webrtc.org as a reviewer. FYI - We have a tool 'git cl owners' that will help you find all necessary owners for a CL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== remove unnecessary double allocation BUG= ========== to ========== remove unnecessary double allocation BUG= ==========
kthelgason@webrtc.org changed reviewers: + tkchin@webrtc.org
On 2016/08/09 14:01:15, magjed_webrtc wrote: > Nice! lgtm > > I'm not an owner of this file yet, so you have to add mailto:tkchin@webrtc.org as a > reviewer. > > FYI - We have a tool 'git cl owners' that will help you find all necessary > owners for a CL. Ah, thanks for the tip! cc/tkchin
lgtm
The CQ bit was checked by tkchin@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/9438) ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/11753) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/16995)
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/9447) ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_dbg/builds/1727) ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_rel/builds/1749) ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/9447) ios_api_framework on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...) ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/11694) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/17004) ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/15654)
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_gn_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/11410)
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== remove unnecessary double allocation BUG= ========== to ========== remove unnecessary double allocation BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== remove unnecessary double allocation BUG= ========== to ========== remove unnecessary double allocation BUG= Committed: https://crrev.com/3e3ebe6937f2593d864566148329b658b6fa52dc Cr-Commit-Position: refs/heads/master@{#13744} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3e3ebe6937f2593d864566148329b658b6fa52dc Cr-Commit-Position: refs/heads/master@{#13744} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
