Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2226823003: Set the event log in Channel from AudioSendStream (Closed)

Created:
4 years, 4 months ago by terelius
Modified:
4 years, 3 months ago
Reviewers:
the sun, ivoc, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, mflodman, hlundin-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Set the event log in Channel from AudioSendStream. This will re-enable logging of outgoing audio packets. BUG=webrtc:6195 Committed: https://crrev.com/e035e2d26f9b6ef0a6a5b262fae775080f91bacf Cr-Commit-Position: refs/heads/master@{#14331}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : Registration order and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M webrtc/audio/audio_send_stream.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/audio/audio_send_stream.cc View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 2 6 chunks +15 lines, -5 lines 0 comments Download
M webrtc/call/call.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
terelius
PTAL
4 years, 4 months ago (2016-08-19 11:12:49 UTC) #2
ivoc
LGTM.
4 years, 4 months ago (2016-08-19 11:20:42 UTC) #3
stefan-webrtc
lgtm
4 years, 4 months ago (2016-08-23 10:03:23 UTC) #4
stefan-webrtc
I would however suggest that you get someone who's a webrtc/audio owner to approve too. ...
4 years, 4 months ago (2016-08-23 10:04:31 UTC) #6
the sun
lgtm https://codereview.webrtc.org/2226823003/diff/20001/webrtc/audio/audio_send_stream.cc File webrtc/audio/audio_send_stream.cc (right): https://codereview.webrtc.org/2226823003/diff/20001/webrtc/audio/audio_send_stream.cc#newcode106 webrtc/audio/audio_send_stream.cc:106: channel_proxy_->SetRtcEventLog(nullptr); super nit: registering methods are called in ...
4 years, 4 months ago (2016-08-23 10:15:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2226823003/40001
4 years, 3 months ago (2016-09-20 13:58:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-20 14:39:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2226823003/40001
4 years, 3 months ago (2016-09-21 07:57:55 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/16933)
4 years, 3 months ago (2016-09-21 08:12:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2226823003/40001
4 years, 3 months ago (2016-09-21 12:38:20 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-21 13:51:51 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 13:51:57 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e035e2d26f9b6ef0a6a5b262fae775080f91bacf
Cr-Commit-Position: refs/heads/master@{#14331}

Powered by Google App Engine
This is Rietveld 408576698