Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2226383002: Fix regression for h264 VideoToolbox entering background. (Closed)

Created:
4 years, 4 months ago by tkchin_webrtc
Modified:
4 years, 4 months ago
Reviewers:
Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman, magjed_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix regression for h264 VideoToolbox entering background. We need to check the pool to make sure that the encoder session is valid. Otherwise, it appears as if the encoder just does not output frames. NOTRY=True BUG= Committed: https://crrev.com/4c45234b81c7dead5fd376893ad3e2f3e2852f15 Cr-Commit-Position: refs/heads/master@{#13698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm View 1 chunk +19 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkchin_webrtc
4 years, 4 months ago (2016-08-09 19:31:16 UTC) #4
Chuck
lgtm
4 years, 4 months ago (2016-08-09 19:40:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2226383002/1
4 years, 4 months ago (2016-08-09 19:54:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 20:02:03 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 20:02:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c45234b81c7dead5fd376893ad3e2f3e2852f15
Cr-Commit-Position: refs/heads/master@{#13698}

Powered by Google App Engine
This is Rietveld 408576698