Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2225333002: Migrated GN target :audio_classifier_test (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Migrated GN target :audio_classifier_test Migrated GN target :audio_classifier_test from webrtc/modules/audio_coding/neteq/neteq_tests.gypi NOTRY=True BUG=webrtc:6190 Committed: https://crrev.com/6391012514b1f9f268cfeb9ca2069203f2d49378 Cr-Commit-Position: refs/heads/master@{#13706}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added missing GN dependency to GYP. #

Patch Set 3 : Rebase on top of master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
aleloi
Here is the first of 6 neteq tools targets. A whole batch of them! PTAL ...
4 years, 4 months ago (2016-08-09 12:13:12 UTC) #3
kjellander_webrtc
lgtm with the suggestion resolved. https://codereview.webrtc.org/2225333002/diff/1/webrtc/modules/audio_coding/BUILD.gn File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2225333002/diff/1/webrtc/modules/audio_coding/BUILD.gn#newcode1389 webrtc/modules/audio_coding/BUILD.gn:1389: "../../system_wrappers:system_wrappers_default", Can you add ...
4 years, 4 months ago (2016-08-09 21:20:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2225333002/40001
4 years, 4 months ago (2016-08-10 11:34:39 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 11:41:20 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 11:41:31 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6391012514b1f9f268cfeb9ca2069203f2d49378
Cr-Commit-Position: refs/heads/master@{#13706}

Powered by Google App Engine
This is Rietveld 408576698