Cleaned out boundingSet member from TMMBRHelp class

Cleaned out boundingSet member from TMMBRHelp class

BUG=webrtc:5565
R=philipel@webrtc.org

Committed: https://crrev.com/daa90a7e35084eb1f983122b70c675146fee2350
Cr-Commit-Position: refs/heads/master@{#13702}

[danilchap, 2016-08-08 12:09:23]

danilchap@webrtc.org changed reviewers:
+ philipel@webrtc.org

[danilchap, 2016-08-08 12:09:23]

Next small step clearing TMMBRHelper.
Can you check new code is as correct as old one, i.e. that I didn't miss any
edge cases, specially where I removed run-time checks (sometimes replacing them
with DCHECKs, sometimes even omitting DCHECKS, assuming silently)

[philipel, 2016-08-09 12:00:24]

https://codereview.webrtc.org/2224933002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/tmmbr_help.cc (right):

https://codereview.webrtc.org/2224933002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/tmmbr_help.cc:88: RTC_DCHECK_LE(numBoundingSet,
_candidateSet.size());
Earlier if we failed to find a bounding set then it would result in -1 to be
returned from RTCPReceiver::UpdateTMMBR. I can't find any place where the return
value of RTCPReceiver::UpdateTMMBR is actually used.

So this looks like a potential change in behavior, but the question is if bad
input can trigger these DCHECKS or if it is a programming error. If bad input
can trigger this then don't use DCHECKS.

[danilchap, 2016-08-09 13:02:13]

https://codereview.webrtc.org/2224933002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/tmmbr_help.cc (right):

https://codereview.webrtc.org/2224933002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/tmmbr_help.cc:88: RTC_DCHECK_LE(numBoundingSet,
_candidateSet.size());
On 2016/08/09 12:00:24, philipel wrote:
> Earlier if we failed to find a bounding set then it would result in -1 to be
> returned from RTCPReceiver::UpdateTMMBR. I can't find any place where the
return
> value of RTCPReceiver::UpdateTMMBR is actually used.
> 
> So this looks like a potential change in behavior, but the question is if bad
> input can trigger these DCHECKS or if it is a programming error. If bad input
> can trigger this then don't use DCHECKS.

yes, DCHECK shouldn't be used to validate bad input.

This DCHECKS state that function below can't return empty bounding set nor can
it return more items in bounding set than was in the candidate set. i.e. there
is no such thing as 'failed to find a bounding set' for non-empty candidate set.
I dare to put those DCHECKS only after that function was cleaned.

[philipel, 2016-08-09 13:09:13]

lgtm

[danilchap, 2016-08-10 09:14:06]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-08-10 09:14:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-10 09:16:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 09:16:21]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7316)

[danilchap, 2016-08-10 09:22:47]

Description was changed from

==========
Cleaned out boundingSet member from TMMBRHelp class
==========

to

==========
Cleaned out boundingSet member from TMMBRHelp class

BUG=webrtc:5565
==========

[danilchap, 2016-08-10 09:30:14]

Description was changed from

==========
Cleaned out boundingSet member from TMMBRHelp class

BUG=webrtc:5565
==========

to

==========
Cleaned out boundingSet member from TMMBRHelp class

BUG=webrtc:5565
R=philipel@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/daa90a7e35084eb1f983122b7...
==========

[danilchap, 2016-08-10 09:30:15]

Committed patchset #2 (id:20001) manually as
daa90a7e35084eb1f983122b70c675146fee2350 (presubmit successful).

[commit-bot: I haz the power, 2016-08-10 09:30:16]

Description was changed from

==========
Cleaned out boundingSet member from TMMBRHelp class

BUG=webrtc:5565
R=philipel@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/daa90a7e35084eb1f983122b7...
==========

to

==========
Cleaned out boundingSet member from TMMBRHelp class

BUG=webrtc:5565
R=philipel@webrtc.org

Committed: https://crrev.com/daa90a7e35084eb1f983122b70c675146fee2350
Cr-Commit-Position: refs/heads/master@{#13702}
==========