Compilerwarning possible loss of data in file port.h

Compilerwarning possible loss of data in file port.h

BUG=webrtc:6179
Committed: https://crrev.com/120306623679068300070d258a59e09f455fb2c7
Cr-Commit-Position: refs/heads/master@{#14671}

[pthatcher1, 2016-08-10 16:53:03]

Description was changed from

==========
Compilerwarning possible loss of data in file port.h

BUG=BUG=webrtc:6179

TBR=pthatcher@webrtc.org
==========

to

==========
Compilerwarning possible loss of data in file port.h

BUG=webrtc:6179
==========

[pthatcher1, 2016-08-10 16:53:03]

pthatcher@webrtc.org changed reviewers:
+ honghaiz@webrtc.org

[pthatcher1, 2016-08-10 16:53:48]

lgtm

Honghai, can you review?

[honghaiz3, 2016-08-10 17:09:23]

https://codereview.webrtc.org/2224323002/diff/1/webrtc/p2p/base/port.h
File webrtc/p2p/base/port.h (right):

https://codereview.webrtc.org/2224323002/diff/1/webrtc/p2p/base/port.h#newcod...
webrtc/p2p/base/port.h:696: int64_t receiving_timeout_;
This is a delta-time, so 32 bits should be sufficient. 
Can you just change the int64_t to int in set_receiving_timeout?

[honghaiz3, 2016-10-05 19:29:15]

On 2016/08/10 17:09:23, honghaiz3 wrote:
> https://codereview.webrtc.org/2224323002/diff/1/webrtc/p2p/base/port.h
> File webrtc/p2p/base/port.h (right):
> 
>
https://codereview.webrtc.org/2224323002/diff/1/webrtc/p2p/base/port.h#newcod...
> webrtc/p2p/base/port.h:696: int64_t receiving_timeout_;
> This is a delta-time, so 32 bits should be sufficient. 
> Can you just change the int64_t to int in set_receiving_timeout?

Hi, are you going to change it and land the CL?

[honghaiz3, 2016-10-14 19:28:21]

lgtm

[honghaiz3, 2016-10-18 20:25:25]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-10-18 20:25:25]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2224323002/#ps20001 (title:
"Compilerwarning possible loss of data in file port.h")

[commit-bot: I haz the power, 2016-10-18 20:25:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-10-18 21:00:06]

Description was changed from

==========
Compilerwarning possible loss of data in file port.h

BUG=webrtc:6179
==========

to

==========
Compilerwarning possible loss of data in file port.h

BUG=webrtc:6179
==========

[commit-bot: I haz the power, 2016-10-18 21:00:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-18 21:00:09]

Description was changed from

==========
Compilerwarning possible loss of data in file port.h

BUG=webrtc:6179
==========

to

==========
Compilerwarning possible loss of data in file port.h

BUG=webrtc:6179

Committed: https://crrev.com/120306623679068300070d258a59e09f455fb2c7
Cr-Commit-Position: refs/heads/master@{#14671}
==========

[commit-bot: I haz the power, 2016-10-18 21:00:10]

Patchset 2 (id:??) landed as
https://crrev.com/120306623679068300070d258a59e09f455fb2c7
Cr-Commit-Position: refs/heads/master@{#14671}