Probe bitrate estimator correction.

Probe bitrate estimator correction.

Since the interval between the timestamps does not include the send/receive
time of the last/first packet we correct the interval by adding the average
of the interval between probing packets.

BUG=webrtc:5859
R=mflodman@webrtc.org, stefan@webrtc.org

Committed: https://crrev.com/bf8a2c94ce32d64da2fae5c21c727555f2036585
Cr-Commit-Position: refs/heads/master@{#13719}

[philipel, 2016-08-09 11:30:48]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org, terelius@webrtc.org

[stefan-webrtc, 2016-08-09 11:37:14]

https://codereview.webrtc.org/2224173003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/probe_bitrate_estimator.h (right):

https://codereview.webrtc.org/2224173003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/probe_bitrate_estimator.h:26: bool valid()
const;
Valid() since this doesn't simply return the member variable valid_. Maybe even
IsValid()

https://codereview.webrtc.org/2224173003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/probe_bitrate_estimator_unittest.cc
(right):

https://codereview.webrtc.org/2224173003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/probe_bitrate_estimator_unittest.cc:54:
CheckResult(0, 8 * 100000, 10, 40);
I don't follow why 8 * 100000 is easier to understand than 800000. Should we
express these in terms of the send times and arrival times above instead?

[philipel, 2016-08-09 12:10:46]

https://codereview.webrtc.org/2224173003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/probe_bitrate_estimator.h (right):

https://codereview.webrtc.org/2224173003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/probe_bitrate_estimator.h:26: bool valid()
const;
On 2016/08/09 11:37:14, stefan-webrtc (holmer) wrote:
> Valid() since this doesn't simply return the member variable valid_. Maybe
even
> IsValid()

This is a cheap function:
https://google.github.io/styleguide/cppguide.html#Function_Names so I use lower
case to show that.

https://codereview.webrtc.org/2224173003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/probe_bitrate_estimator_unittest.cc
(right):

https://codereview.webrtc.org/2224173003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/probe_bitrate_estimator_unittest.cc:54:
CheckResult(0, 8 * 100000, 10, 40);
On 2016/08/09 11:37:14, stefan-webrtc (holmer) wrote:
> I don't follow why 8 * 100000 is easier to understand than 800000. Should we
> express these in terms of the send times and arrival times above instead?

It's not, fixed.

[stefan-webrtc, 2016-08-09 12:15:25]

lgtm

[philipel, 2016-08-09 12:16:47]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2016-08-09 12:16:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-09 12:34:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 12:34:54]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7280)

[philipel, 2016-08-09 13:06:19]

philipel@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[philipel, 2016-08-09 13:06:19]

Magnus, PTAL on BUILD.gn

[mflodman, 2016-08-10 10:28:04]

BUILD.gn LGTM

[philipel, 2016-08-10 12:59:04]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2016-08-10 12:59:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-10 13:05:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 13:05:32]

Try jobs failed on following builders:
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)

[philipel, 2016-08-10 14:23:36]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2016-08-10 14:23:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-10 16:45:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 16:45:59]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/15506)

[philipel, 2016-08-10 17:00:58]

Description was changed from

==========
Probe bitrate estimator correction.

Since the interval between the timestamps does not include the send/receive
time of the last/first packet we correct the interval by adding the average
of the interval between probing packets.

BUG=webrtc:5859
==========

to

==========
Probe bitrate estimator correction.

Since the interval between the timestamps does not include the send/receive
time of the last/first packet we correct the interval by adding the average
of the interval between probing packets.

BUG=webrtc:5859
R=mflodman@webrtc.org, stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/bf8a2c94ce32d64da2fae5c21...
==========

[commit-bot: I haz the power, 2016-08-10 17:00:59]

Description was changed from

==========
Probe bitrate estimator correction.

Since the interval between the timestamps does not include the send/receive
time of the last/first packet we correct the interval by adding the average
of the interval between probing packets.

BUG=webrtc:5859
R=mflodman@webrtc.org, stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/bf8a2c94ce32d64da2fae5c21...
==========

to

==========
Probe bitrate estimator correction.

Since the interval between the timestamps does not include the send/receive
time of the last/first packet we correct the interval by adding the average
of the interval between probing packets.

BUG=webrtc:5859
R=mflodman@webrtc.org, stefan@webrtc.org

Committed: https://crrev.com/bf8a2c94ce32d64da2fae5c21c727555f2036585
Cr-Commit-Position: refs/heads/master@{#13719}
==========

[philipel, 2016-08-10 17:00:59]

Committed patchset #2 (id:20001) manually as
bf8a2c94ce32d64da2fae5c21c727555f2036585 (presubmit successful).