Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2224063004: Implement PlayoutDelay extension as a trait (Closed)

Created:
4 years, 4 months ago by danilchap
Modified:
4 years, 3 months ago
Reviewers:
Irfan, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman, Irfan
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Implement PlayoutDelay extension as a trait to be used with rtp::Packet class BUG=webrtc:1994 R=isheriff@chromium.org, stefan@webrtc.org Committed: https://crrev.com/08b0351ddd0469c8b0aa7c028ac93878a350e593 Cr-Commit-Position: refs/heads/master@{#14105}

Patch Set 1 #

Patch Set 2 : variable spelling #

Patch Set 3 : Avoid mutating output parameters when Parse returns false #

Total comments: 4

Patch Set 4 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
M webrtc/test/fuzzers/rtp_packet_fuzzer.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
danilchap
Before spreading RtpPacket class to RtpSenderVideo, need it to support PlayoutDelay rtp header extension in ...
4 years, 4 months ago (2016-08-15 14:18:31 UTC) #3
Irfan
https://codereview.chromium.org/2224063004/diff/40001/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h File webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h (right): https://codereview.chromium.org/2224063004/diff/40001/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h#newcode87 webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h:87: static bool Parse(const uint8_t* data, int* min_ms, int* max_ms); ...
4 years, 4 months ago (2016-08-16 17:22:14 UTC) #4
danilchap
https://codereview.webrtc.org/2224063004/diff/40001/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h File webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h (right): https://codereview.webrtc.org/2224063004/diff/40001/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h#newcode87 webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h:87: static bool Parse(const uint8_t* data, int* min_ms, int* max_ms); ...
4 years, 4 months ago (2016-08-17 07:42:39 UTC) #5
Irfan
lgtm
4 years, 4 months ago (2016-08-17 16:41:38 UTC) #6
danilchap
ping Stefan Can I please get an approve for webrtc/test/ ?
4 years, 4 months ago (2016-08-22 06:37:32 UTC) #7
stefan-webrtc
lgtm
4 years, 3 months ago (2016-09-07 13:02:52 UTC) #8
danilchap
4 years, 3 months ago (2016-09-07 13:08:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
08b0351ddd0469c8b0aa7c028ac93878a350e593 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698