Migrated GN target :neteq_opus_quality_test

Migrated GN target :neteq_opus_quality_test

Migrated GN target :neteq_opus_quality_test from
webrtc/modules/audio_coding/neteq/neteq_tests.gypi

NOTRY=True

BUG=webrtc:6190, webrtc:2692
Committed: https://crrev.com/630c6d58d3358a5f12a32b167a9d9abe0bee1e36
Cr-Commit-Position: refs/heads/master@{#13701}

[aleloi, 2016-08-09 12:20:30]

aleloi@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[aleloi, 2016-08-09 12:20:31]

GN target #5 of the 6 neteq test targets.

[kjellander_webrtc, 2016-08-09 21:18:07]

lgtm with a question.

https://codereview.webrtc.org/2223933004/diff/1/webrtc/modules/audio_coding/B...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2223933004/diff/1/webrtc/modules/audio_coding/B...
webrtc/modules/audio_coding/BUILD.gn:1385:
"neteq/test/neteq_opus_quality_test.cc",
I guess it's not as easy as just fixing the Chromium Clang warnings in this
file? I guess they also need to be fixed in all dependencies in order to get rid
of the config below? (same to the other CLs in this batch).

[aleloi, 2016-08-10 08:24:17]

On 2016/08/09 21:18:07, kjellander_webrtc wrote:
> lgtm with a question.
> 
>
https://codereview.webrtc.org/2223933004/diff/1/webrtc/modules/audio_coding/B...
> File webrtc/modules/audio_coding/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2223933004/diff/1/webrtc/modules/audio_coding/B...
> webrtc/modules/audio_coding/BUILD.gn:1385:
> "neteq/test/neteq_opus_quality_test.cc",
> I guess it's not as easy as just fixing the Chromium Clang warnings in this
> file? I guess they also need to be fixed in all dependencies in order to get
rid
> of the config below? (same to the other CLs in this batch).

There is one error outside of this test:

In file included from
../../webrtc/modules/audio_coding/neteq/test/neteq_opus_quality_test.cc:13:
In file included from
../../webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h:19:
../../webrtc/modules/audio_coding/neteq/tools/audio_sink.h:50:70: error:
[chromium-style] virtual methods with non-empty bodies shouldn't be declared
inline.
  bool WriteArray(const int16_t* audio, size_t num_samples) override {

I fixed the other ones.

[aleloi, 2016-08-10 08:26:13]

Description was changed from

==========
Migrated GN target :neteq_opus_quality_test

Migrated GN target :neteq_opus_quality_test from
webrtc/modules/audio_coding/neteq/neteq_tests.gypi

NOTRY=True

BUG=webrtc:6190
==========

to

==========
Migrated GN target :neteq_opus_quality_test

Migrated GN target :neteq_opus_quality_test from
webrtc/modules/audio_coding/neteq/neteq_tests.gypi

NOTRY=True

BUG=webrtc:6190
==========

[aleloi, 2016-08-10 08:26:13]

aleloi@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[aleloi, 2016-08-10 08:27:18]

hlundin-webrtc@: I did some small changes on neteq_opus_quality_test to fix
issues that chromium-style complained about. Can you take a look?

[aleloi, 2016-08-10 08:28:14]

Description was changed from

==========
Migrated GN target :neteq_opus_quality_test

Migrated GN target :neteq_opus_quality_test from
webrtc/modules/audio_coding/neteq/neteq_tests.gypi

NOTRY=True

BUG=webrtc:6190
==========

to

==========
Migrated GN target :neteq_opus_quality_test

Migrated GN target :neteq_opus_quality_test from
webrtc/modules/audio_coding/neteq/neteq_tests.gypi

NOTRY=True

BUG=webrtc:6190, webrtc:2692
==========

[hlundin-webrtc, 2016-08-10 08:57:21]

webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.*: lgtm

[aleloi, 2016-08-10 09:09:45]

The CQ bit was checked by aleloi@webrtc.org

[aleloi, 2016-08-10 09:09:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2223933004/#ps20001 (title:
"Fixed chromium-style clang errors in neteq_quality_test")

[commit-bot: I haz the power, 2016-08-10 09:09:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-10 09:11:34]

Description was changed from

==========
Migrated GN target :neteq_opus_quality_test

Migrated GN target :neteq_opus_quality_test from
webrtc/modules/audio_coding/neteq/neteq_tests.gypi

NOTRY=True

BUG=webrtc:6190, webrtc:2692
==========

to

==========
Migrated GN target :neteq_opus_quality_test

Migrated GN target :neteq_opus_quality_test from
webrtc/modules/audio_coding/neteq/neteq_tests.gypi

NOTRY=True

BUG=webrtc:6190, webrtc:2692
==========

[commit-bot: I haz the power, 2016-08-10 09:11:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-10 09:11:55]

Description was changed from

==========
Migrated GN target :neteq_opus_quality_test

Migrated GN target :neteq_opus_quality_test from
webrtc/modules/audio_coding/neteq/neteq_tests.gypi

NOTRY=True

BUG=webrtc:6190, webrtc:2692
==========

to

==========
Migrated GN target :neteq_opus_quality_test

Migrated GN target :neteq_opus_quality_test from
webrtc/modules/audio_coding/neteq/neteq_tests.gypi

NOTRY=True

BUG=webrtc:6190, webrtc:2692

Committed: https://crrev.com/630c6d58d3358a5f12a32b167a9d9abe0bee1e36
Cr-Commit-Position: refs/heads/master@{#13701}
==========

[commit-bot: I haz the power, 2016-08-10 09:11:56]

Patchset 2 (id:??) landed as
https://crrev.com/630c6d58d3358a5f12a32b167a9d9abe0bee1e36
Cr-Commit-Position: refs/heads/master@{#13701}