Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2223343004: Migrated GN target :neteq_speed_test (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Migrated GN target :neteq_speed_test Migrated GN target :neteq_speed_test from webrtc/modules/audio_coding/neteq/neteq.gypi NOTRY=True BUG=webrtc:6190 Committed: https://crrev.com/116fd61599d1497f58f66faaa67b90482df9124d Cr-Commit-Position: refs/heads/master@{#13704}

Patch Set 1 #

Patch Set 2 : Depended on correct target this time. #

Patch Set 3 : Changed the gyp file to depend on more correct targents #

Patch Set 4 : Updated to correct GYP deps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 1 chunk +16 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_tests.gypi View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
aleloi
GN target #3 out of the 6 neteq test targets.
4 years, 4 months ago (2016-08-09 12:19:11 UTC) #2
kjellander_webrtc
lgtm
4 years, 4 months ago (2016-08-09 21:19:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2223343004/30002
4 years, 4 months ago (2016-08-10 11:15:25 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:30002)
4 years, 4 months ago (2016-08-10 11:16:41 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 11:16:56 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/116fd61599d1497f58f66faaa67b90482df9124d
Cr-Commit-Position: refs/heads/master@{#13704}

Powered by Google App Engine
This is Rietveld 408576698