Fix issue where the number of packets reported in tests/simulations sometimes are negative.

webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 95 matching lines @@
 }
 
 FeedbackPacket* RembReceiver::GetFeedback(int64_t now_ms) {
   BWE_TEST_LOGGING_CONTEXT("Remb");
   uint32_t estimated_bps = 0;
   RembFeedback* feedback = NULL;
   if (LatestEstimate(&estimated_bps)) {
     StatisticianMap statisticians = recv_stats_->GetActiveStatisticians();
     RTCPReportBlock report_block;
     if (!statisticians.empty()) {
-      report_block = BuildReportBlock(statisticians.begin()->second);
+      latest_report_block_ = BuildReportBlock(statisticians.begin()->second);
     }
 
     feedback = new RembFeedback(flow_id_, now_ms * 1000, last_feedback_ms_,
-                                estimated_bps, report_block);
+                                estimated_bps, latest_report_block_);
     last_feedback_ms_ = now_ms;
 
     double estimated_kbps = static_cast<double>(estimated_bps) / 1000.0;
     RTC_UNUSED(estimated_kbps);
     if (plot_estimate_) {
       BWE_TEST_LOGGING_PLOT(0, estimate_log_prefix_,
                             clock_.TimeInMilliseconds(), estimated_kbps);
     }
   }
   return feedback;
 }
 
 void RembReceiver::OnReceiveBitrateChanged(const std::vector<uint32_t>& ssrcs,
                                            uint32_t bitrate) {}
 
 RTCPReportBlock RembReceiver::BuildReportBlock(
     StreamStatistician* statistician) {
   RTCPReportBlock report_block;
   RtcpStatistics stats;
-  if (!statistician->GetStatistics(&stats, true))
-    return report_block;
+  RTC_DCHECK(statistician->GetStatistics(&stats, true));
   report_block.fractionLost = stats.fraction_lost;
   report_block.cumulativeLost = stats.cumulative_lost;
   report_block.extendedHighSeqNum = stats.extended_max_sequence_number;
   report_block.jitter = stats.jitter;
   return report_block;
 }
 
 bool RembReceiver::LatestEstimate(uint32_t* estimate_bps) {
   if (latest_estimate_bps_ < 0) {
     std::vector<uint32_t> ssrcs;
     uint32_t bps = 0;
     if (!estimator_->LatestEstimate(&ssrcs, &bps)) {
       return false;
     }
     latest_estimate_bps_ = bps;
   }
   *estimate_bps = latest_estimate_bps_;
   return true;
 }
 
 }  // namespace bwe
 }  // namespace testing
 }  // namespace webrtc