Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 2222643002: Adding GN targets for audioproc, audioproc_f and unpack_aecdump (Closed)

Created:
4 years, 4 months ago by peah-webrtc
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding GN targets for audioproc, audioproc_f and unpack_aecdump BUG=webrtc:6171 NOTRY=True Committed: https://crrev.com/c3ec1fd23c67b087f10300618195f3cd559e1b72 Cr-Commit-Position: refs/heads/master@{#13667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -0 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
peah-webrtc
4 years, 4 months ago (2016-08-05 21:37:14 UTC) #4
kjellander_webrtc
lgtm, I ran the GN trybots and added NOTRY=True to save some time here.
4 years, 4 months ago (2016-08-08 05:32:05 UTC) #6
peah-webrtc
On 2016/08/08 05:32:05, kjellander_webrtc wrote: > lgtm, > I ran the GN trybots and added ...
4 years, 4 months ago (2016-08-08 06:15:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2222643002/1
4 years, 4 months ago (2016-08-08 06:15:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 06:19:35 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 06:19:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3ec1fd23c67b087f10300618195f3cd559e1b72
Cr-Commit-Position: refs/heads/master@{#13667}

Powered by Google App Engine
This is Rietveld 408576698