Fix warnings, simplify ADM.

Fix warnings, simplify ADM.

This is in preparation for adding a gn target for audio_device_tests.

BUG=webrtc:6170, webrtc:163
NOTRY=True

Committed: https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be
Cr-Commit-Position: refs/heads/master@{#13768}

[Max Morin WebRTC, 2016-08-05 14:46:55]

Description was changed from

==========
Fix warnings, simplify ADM.

This is in preparation for adding a gn target for audio_device_tests.

BUG=webrtc:6170,webrtc:163
==========

to

==========
Fix warnings, simplify ADM.

This is in preparation for adding a gn target for audio_device_tests.

BUG=webrtc:6170,webrtc:163
==========

[Max Morin WebRTC, 2016-08-05 14:46:55]

maxmorin@webrtc.org changed reviewers:
+ kjellander@webrtc.org, niklas.enbom@webrtc.org

[Max Morin WebRTC, 2016-08-05 14:58:26]

Please take a look at this cleanup CL.
Niklas: PTAL at audio_device/*.
Kjellander: PTAL at build files.

[kjellander_webrtc, 2016-08-08 05:44:43]

On 2016/08/05 14:58:26, Max Morin wrote:
> Please take a look at this cleanup CL.
> Niklas: PTAL at audio_device/*.
> Kjellander: PTAL at build files.

lgtm for *.gn+*.gypi, although I'll leave the rest of the review to the
remaining folks

Nice to see some work on bug 163. Getting that fixed would remove a lot of
boilerplate configs and would make it possible for us to keep our code cleaner.

[niklas.enbom, 2016-08-08 23:23:30]

Quick glance, it looks like EnableBuiltInNS still doesn't have a chrome
implementation, are you doing that as well?

On 2016/08/08 05:44:43, kjellander_webrtc wrote:
> On 2016/08/05 14:58:26, Max Morin wrote:
> > Please take a look at this cleanup CL.
> > Niklas: PTAL at audio_device/*.
> > Kjellander: PTAL at build files.
> 
> lgtm for *.gn+*.gypi, although I'll leave the rest of the review to the
> remaining folks
> 
> Nice to see some work on bug 163. Getting that fixed would remove a lot of
> boilerplate configs and would make it possible for us to keep our code
cleaner.

[Max Morin WebRTC, 2016-08-09 10:22:34]

On 2016/08/08 23:23:30, niklas.enbom wrote:
> Quick glance, it looks like EnableBuiltInNS still doesn't have a chrome
> implementation, are you doing that as well?
> 
> On 2016/08/08 05:44:43, kjellander_webrtc wrote:
> > On 2016/08/05 14:58:26, Max Morin wrote:
> > > Please take a look at this cleanup CL.
> > > Niklas: PTAL at audio_device/*.
> > > Kjellander: PTAL at build files.
> > 
> > lgtm for *.gn+*.gypi, although I'll leave the rest of the review to the
> > remaining folks
> > 
> > Nice to see some work on bug 163. Getting that fixed would remove a lot of
> > boilerplate configs and would make it possible for us to keep our code
> cleaner.

I created https://codereview.chromium.org/2225263003/.

[niklas.enbom, 2016-08-09 20:08:20]

On 2016/08/09 10:22:34, Max Morin wrote:
I haven't looked at this code in a while and it's quite confusing with
AudioDeviceModule and AudioDeviceGeneric, but I guess that's a topic for another
discussion... lgtm after landing chromium CL.

> On 2016/08/08 23:23:30, niklas.enbom wrote:
> > Quick glance, it looks like EnableBuiltInNS still doesn't have a chrome
> > implementation, are you doing that as well?
> > 
> > On 2016/08/08 05:44:43, kjellander_webrtc wrote:
> > > On 2016/08/05 14:58:26, Max Morin wrote:
> > > > Please take a look at this cleanup CL.
> > > > Niklas: PTAL at audio_device/*.
> > > > Kjellander: PTAL at build files.
> > > 
> > > lgtm for *.gn+*.gypi, although I'll leave the rest of the review to the
> > > remaining folks
> > > 
> > > Nice to see some work on bug 163. Getting that fixed would remove a lot of
> > > boilerplate configs and would make it possible for us to keep our code
> > cleaner.
> 
> I created https://codereview.chromium.org/2225263003/.

[kjellander_webrtc, 2016-08-15 17:06:45]

Description was changed from

==========
Fix warnings, simplify ADM.

This is in preparation for adding a gn target for audio_device_tests.

BUG=webrtc:6170,webrtc:163
==========

to

==========
Fix warnings, simplify ADM.

This is in preparation for adding a gn target for audio_device_tests.

BUG=webrtc:6170,webrtc:163
NOTRY=True
==========

[kjellander_webrtc, 2016-08-15 17:07:39]

On 2016/08/09 20:08:20, niklas.enbom wrote:
> On 2016/08/09 10:22:34, Max Morin wrote:
> I haven't looked at this code in a while and it's quite confusing with
> AudioDeviceModule and AudioDeviceGeneric, but I guess that's a topic for
another
> discussion... lgtm after landing chromium CL.
> 
> > On 2016/08/08 23:23:30, niklas.enbom wrote:
> > > Quick glance, it looks like EnableBuiltInNS still doesn't have a chrome
> > > implementation, are you doing that as well?
> > > 
> > > On 2016/08/08 05:44:43, kjellander_webrtc wrote:
> > > > On 2016/08/05 14:58:26, Max Morin wrote:
> > > > > Please take a look at this cleanup CL.
> > > > > Niklas: PTAL at audio_device/*.
> > > > > Kjellander: PTAL at build files.
> > > > 
> > > > lgtm for *.gn+*.gypi, although I'll leave the rest of the review to the
> > > > remaining folks
> > > > 
> > > > Nice to see some work on bug 163. Getting that fixed would remove a lot
of
> > > > boilerplate configs and would make it possible for us to keep our code
> > > cleaner.
> > 
> > I created https://codereview.chromium.org/2225263003/.

It appears you need to fix some iOS specific errors.

[Max Morin WebRTC, 2016-08-16 07:47:47]

The CQ bit was checked by maxmorin@webrtc.org

[Max Morin WebRTC, 2016-08-16 07:47:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, niklas.enbom@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2222563002/#ps40001 (title:
"Fix IOS compile.")

[commit-bot: I haz the power, 2016-08-16 07:47:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-16 07:56:13]

Description was changed from

==========
Fix warnings, simplify ADM.

This is in preparation for adding a gn target for audio_device_tests.

BUG=webrtc:6170,webrtc:163
NOTRY=True
==========

to

==========
Fix warnings, simplify ADM.

This is in preparation for adding a gn target for audio_device_tests.

BUG=webrtc:6170,webrtc:163
NOTRY=True
==========

[commit-bot: I haz the power, 2016-08-16 07:56:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-16 07:56:22]

Description was changed from

==========
Fix warnings, simplify ADM.

This is in preparation for adding a gn target for audio_device_tests.

BUG=webrtc:6170,webrtc:163
NOTRY=True
==========

to

==========
Fix warnings, simplify ADM.

This is in preparation for adding a gn target for audio_device_tests.

BUG=webrtc:6170,webrtc:163
NOTRY=True

Committed: https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be
Cr-Commit-Position: refs/heads/master@{#13768}
==========

[commit-bot: I haz the power, 2016-08-16 07:56:23]

Patchset 3 (id:??) landed as
https://crrev.com/88e31a3fd8a59a46bed01e1d1e6e1e01eb3681be
Cr-Commit-Position: refs/heads/master@{#13768}