Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2222243002: Remove memcheck suppressions pointing to libnss3.so (Closed)

Created:
4 years, 4 months ago by joachim
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove memcheck suppressions pointing to libnss3.so NSS has been replaced by BoringSSL/OpenSSL on all platforms, so the memcheck suppressions should no longer be required. BUG= R=kjellander@webrtc.org NOTRY=True Committed: https://crrev.com/ed2f1ef369ee073b33a5adc4801456d81caf26a1 Cr-Commit-Position: refs/heads/master@{#13686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M tools/valgrind-webrtc/memcheck/suppressions.txt View 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
joachim
Ptal
4 years, 4 months ago (2016-08-08 23:46:18 UTC) #1
kjellander_webrtc
lgtm, thanks for cleaning this up. I added NOTRY=True for you to save some trybot ...
4 years, 4 months ago (2016-08-09 05:32:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2222243002/1
4 years, 4 months ago (2016-08-09 05:57:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 06:01:36 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 06:01:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed2f1ef369ee073b33a5adc4801456d81caf26a1
Cr-Commit-Position: refs/heads/master@{#13686}

Powered by Google App Engine
This is Rietveld 408576698