Chromium Code Reviews| Index: webrtc/modules/audio_mixer/include/new_audio_conference_mixer.h |
| diff --git a/webrtc/modules/audio_mixer/include/new_audio_conference_mixer.h b/webrtc/modules/audio_mixer/include/new_audio_conference_mixer.h |
| index 844e9ae0fdb67d7d209f141c33e891370d750148..6d7bb2aefbb07cddbba85417d2e05b544b7fc856 100644 |
| --- a/webrtc/modules/audio_mixer/include/new_audio_conference_mixer.h |
| +++ b/webrtc/modules/audio_mixer/include/new_audio_conference_mixer.h |
| @@ -48,9 +48,12 @@ class NewAudioConferenceMixer { |
| bool mixable) = 0; |
| // Performs mixing by asking registered audio sources for audio. The |
| - // mixed result is placed in the provided AudioFrame. Can only be |
| - // called from a single thread. |
| - virtual void Mix(AudioFrame* audio_frame_for_mixing) = 0; |
|
aleloi
2016/08/05 09:52:21
We are moving away from the AudioFrame. In the fut
the sun
2016/08/05 12:26:00
Then why not float* instead of void*?
aleloi
2016/08/05 12:37:14
To do one change at a time, probably. Much of the
|
| + // mixed result is placed in the provided buffer, which is |
| + // guaranteed to be large enough. Can only be called from a single |
| + // thread. |
| + virtual void Mix(int sample_rate, |
| + size_t number_of_channels, |
| + void* audio_data) = 0; |
| // Set the minimum sampling frequency at which to mix. The mixing algorithm |
| // may still choose to mix at a higher samling frequency to avoid |