Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: webrtc/voice_engine/BUILD.gn

Issue 2221103004: Broke out 'level_indicator' of the voice_engine GN target. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed (hopefully) win compile issues. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/voice_engine/level_indicator.h » ('j') | webrtc/voice_engine/level_indicator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/BUILD.gn
diff --git a/webrtc/voice_engine/BUILD.gn b/webrtc/voice_engine/BUILD.gn
index b587d04073fb778585174cb4a694a45bd0440da5..0492919740e2be252e167acb1b56e8a9b3848c32 100644
--- a/webrtc/voice_engine/BUILD.gn
+++ b/webrtc/voice_engine/BUILD.gn
@@ -29,8 +29,6 @@ source_set("voice_engine") {
"include/voe_rtp_rtcp.h",
"include/voe_video_sync.h",
"include/voe_volume_control.h",
- "level_indicator.cc",
- "level_indicator.h",
"monitor_module.cc",
"monitor_module.h",
"network_predictor.cc",
@@ -106,6 +104,20 @@ source_set("voice_engine") {
"../modules/utility",
"../system_wrappers",
]
+
+ public_deps = [
+ ":level_indicator",
kjellander_webrtc 2016/08/09 21:25:17 does it need to be public?
aleloi 2016/08/10 09:08:04 No, it doesn't. I thought it needed to be public b
+ ]
+}
+
+source_set("level_indicator") {
+ sources = [
+ "level_indicator.cc",
+ "level_indicator.h",
+ ]
+
kjellander_webrtc 2016/08/09 21:25:17 Add a dependency on "../common_audio", as well, si
kjellander_webrtc 2016/08/09 21:25:17 Please add dependency on "../base:rtc_base_approve
aleloi 2016/08/10 09:08:04 Done, and also webrtc_common from webrtc/typedefs.
+ configs += [ "..:common_config" ]
+ public_configs = [ "..:common_inherited_config" ]
}
if (rtc_include_tests) {
« no previous file with comments | « no previous file | webrtc/voice_engine/level_indicator.h » ('j') | webrtc/voice_engine/level_indicator.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698