Remove old methods in AudioTransport, make it pass a gn build

Remove old methods in AudioTransport, make it pass a gn build
when building with default warnings.

This is in preparation for making a gn target for audio_device_tests.

BUG=webrtc:6170, webrtc:163
NOTRY=True

Committed: https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896
Cr-Commit-Position: refs/heads/master@{#13759}

[Max Morin WebRTC, 2016-08-05 14:51:43]

Description was changed from

==========
Remove old methods in AudioTransport, make it pass a gn build
when building with default warnings.

This is in preparation for making a gn target for audio_device_tests.

BUG=webrtc:6170, webrtc:163
==========

to

==========
Remove old methods in AudioTransport, make it pass a gn build
when building with default warnings.

This is in preparation for making a gn target for audio_device_tests.

BUG=webrtc:6170, webrtc:163
==========

[Max Morin WebRTC, 2016-08-05 14:51:43]

maxmorin@webrtc.org changed reviewers:
+ kjellander@webrtc.org, niklas.enbom@webrtc.org, pthatcher@webrtc.org

[Max Morin WebRTC, 2016-08-05 15:00:35]

PTAL at this cleanup of AudioTransport.
Kjellander: PTAL at build files.
Niklas: PTAL at audio_device/* and voice_engine/*.
Thatcher: PTAL at webrtc/media/engine/webrtcvoiceengine.cc.

[the sun, 2016-08-05 18:14:30]

solenberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-08-05 18:14:31]

https://codereview.webrtc.org/2219653004/diff/1/webrtc/modules/audio_device/a...
File webrtc/modules/audio_device/audio_transport.cc (right):

https://codereview.webrtc.org/2219653004/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/audio_transport.cc:21: size_t number_of_frames) {}
I think this implementation file is unnecessary. Either just leave them as they
were or, ideally, make the methods pure virtual and force each implementor to
include an empty implementation. Note that the latter is more work as clients
need to be updated before submitting this CL.

https://codereview.webrtc.org/2219653004/diff/1/webrtc/modules/audio_device/i...
File webrtc/modules/audio_device/include/mock_audio_device.h (left):

https://codereview.webrtc.org/2219653004/diff/1/webrtc/modules/audio_device/i...
webrtc/modules/audio_device/include/mock_audio_device.h:128:
MOCK_CONST_METHOD0(BuiltInAECIsEnabled, bool());
Are these changes necessary to make it pass a GN build? To me it looks like they
belong in a separate CL.

[kjellander_webrtc, 2016-08-08 05:29:34]

lgtm for *.gn+*.gypi, although I'll leave the rest of the review to the
remaining folks

[Max Morin WebRTC, 2016-08-08 14:14:53]

The CQ bit was checked by maxmorin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 14:14:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-08 14:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 14:20:07]

Dry run: Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/13178)

[Max Morin WebRTC, 2016-08-08 14:36:50]

The CQ bit was checked by maxmorin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 14:36:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Max Morin WebRTC, 2016-08-08 15:28:57]

PTAL

https://codereview.webrtc.org/2219653004/diff/1/webrtc/modules/audio_device/a...
File webrtc/modules/audio_device/audio_transport.cc (right):

https://codereview.webrtc.org/2219653004/diff/1/webrtc/modules/audio_device/a...
webrtc/modules/audio_device/audio_transport.cc:21: size_t number_of_frames) {}
On 2016/08/05 18:14:31, the sun (OOO until August 22nd wrote:
> I think this implementation file is unnecessary. Either just leave them as
they
> were or, ideally, make the methods pure virtual and force each implementor to
> include an empty implementation. Note that the latter is more work as clients
> need to be updated before submitting this CL.

Ok, they are pure virtual now.

https://codereview.webrtc.org/2219653004/diff/1/webrtc/modules/audio_device/i...
File webrtc/modules/audio_device/include/mock_audio_device.h (left):

https://codereview.webrtc.org/2219653004/diff/1/webrtc/modules/audio_device/i...
webrtc/modules/audio_device/include/mock_audio_device.h:128:
MOCK_CONST_METHOD0(BuiltInAECIsEnabled, bool());
On 2016/08/05 18:14:31, the sun (OOO until August 22nd wrote:
> Are these changes necessary to make it pass a GN build? To me it looks like
they
> belong in a separate CL.

They were accidentally added to the wrong CL :)

[commit-bot: I haz the power, 2016-08-08 16:37:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 16:37:27]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[niklas.enbom, 2016-08-08 20:39:46]

audio_device and VoE lgtm
On 2016/08/08 15:28:57, Max Morin wrote:
> PTAL
> 
>
https://codereview.webrtc.org/2219653004/diff/1/webrtc/modules/audio_device/a...
> File webrtc/modules/audio_device/audio_transport.cc (right):
> 
>
https://codereview.webrtc.org/2219653004/diff/1/webrtc/modules/audio_device/a...
> webrtc/modules/audio_device/audio_transport.cc:21: size_t number_of_frames) {}
> On 2016/08/05 18:14:31, the sun (OOO until August 22nd wrote:
> > I think this implementation file is unnecessary. Either just leave them as
> they
> > were or, ideally, make the methods pure virtual and force each implementor
to
> > include an empty implementation. Note that the latter is more work as
clients
> > need to be updated before submitting this CL.
> 
> Ok, they are pure virtual now.
> 
>
https://codereview.webrtc.org/2219653004/diff/1/webrtc/modules/audio_device/i...
> File webrtc/modules/audio_device/include/mock_audio_device.h (left):
> 
>
https://codereview.webrtc.org/2219653004/diff/1/webrtc/modules/audio_device/i...
> webrtc/modules/audio_device/include/mock_audio_device.h:128:
> MOCK_CONST_METHOD0(BuiltInAECIsEnabled, bool());
> On 2016/08/05 18:14:31, the sun (OOO until August 22nd wrote:
> > Are these changes necessary to make it pass a GN build? To me it looks like
> they
> > belong in a separate CL.
> 
> They were accidentally added to the wrong CL :)

[pthatcher1, 2016-08-08 21:41:57]

lgtm

[kjellander_webrtc, 2016-08-15 16:42:18]

Description was changed from

==========
Remove old methods in AudioTransport, make it pass a gn build
when building with default warnings.

This is in preparation for making a gn target for audio_device_tests.

BUG=webrtc:6170, webrtc:163
==========

to

==========
Remove old methods in AudioTransport, make it pass a gn build
when building with default warnings.

This is in preparation for making a gn target for audio_device_tests.

BUG=webrtc:6170, webrtc:163
NOTRY=True
==========

[kjellander_webrtc, 2016-08-15 18:44:33]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2016-08-15 18:44:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2219653004/#ps40001 (title:
"Fix compile.")

[commit-bot: I haz the power, 2016-08-15 18:44:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-15 18:46:24]

Description was changed from

==========
Remove old methods in AudioTransport, make it pass a gn build
when building with default warnings.

This is in preparation for making a gn target for audio_device_tests.

BUG=webrtc:6170, webrtc:163
NOTRY=True
==========

to

==========
Remove old methods in AudioTransport, make it pass a gn build
when building with default warnings.

This is in preparation for making a gn target for audio_device_tests.

BUG=webrtc:6170, webrtc:163
NOTRY=True
==========

[commit-bot: I haz the power, 2016-08-15 18:46:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-15 18:46:31]

Description was changed from

==========
Remove old methods in AudioTransport, make it pass a gn build
when building with default warnings.

This is in preparation for making a gn target for audio_device_tests.

BUG=webrtc:6170, webrtc:163
NOTRY=True
==========

to

==========
Remove old methods in AudioTransport, make it pass a gn build
when building with default warnings.

This is in preparation for making a gn target for audio_device_tests.

BUG=webrtc:6170, webrtc:163
NOTRY=True

Committed: https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896
Cr-Commit-Position: refs/heads/master@{#13759}
==========

[commit-bot: I haz the power, 2016-08-15 18:46:32]

Patchset 3 (id:??) landed as
https://crrev.com/1aee0b5bd98eade203d8d4c0a05a85414ad15896
Cr-Commit-Position: refs/heads/master@{#13759}