Issue 2218153002: Remove RTPSenderInterface

Issue 2218153002: Remove RTPSenderInterface (Closed)

Created:
4 years, 4 months ago by danilchap

Modified:
4 years, 4 months ago

Reviewers:
åsapersson, stefan-webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Remove RTPSenderInterface Committed: https://crrev.com/5fb291ac8835c573b239c3427cd185388f6d01ed Cr-Commit-Position: refs/heads/master@{#13694}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -71 lines)			Patch
M	webrtc/modules/rtp_rtcp/source/rtp_sender.h	View	8 chunks	+16 lines, -68 lines	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/rtp_sender_video.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (3 generated)

danilchap

The only found user of this interface is RTPSenderVideo that has as much access to ...

4 years, 4 months ago (2016-08-08 08:41:53 UTC) #2

stefan-webrtc

I don't really know the history of this interface. I'm happy to remove it. lgtm

4 years, 4 months ago (2016-08-08 10:14:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2218153002/1

4 years, 4 months ago (2016-08-09 14:38:53 UTC) #6

commit-bot: I haz the power

4 years, 4 months ago (2016-08-09 14:43:39 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5fb291ac8835c573b239c3427cd185388f6d01ed
Cr-Commit-Position: refs/heads/master@{#13694}