Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2217463002: Revert of GN: Create target for video_capture_tests on Linux. (Closed)

Created:
4 years, 4 months ago by guidou
Modified:
4 years, 4 months ago
Reviewers:
mflodman, sakal
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhengzhonghou_agora.io, tterriberry_mozilla.com, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of GN: Create target for video_capture_tests on Linux. (patchset #2 id:20001 of https://codereview.webrtc.org/2207463004/ ) Reason for revert: Breaks bots. See https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder%20%28dbg%29/builds/15490 Original issue's description: > GN: Create target for video_capture_tests on Linux. > > BUG=webrtc:6042 > > Committed: https://crrev.com/171c7fef0a8b7a1598ac87e0349e210372cb974c > Cr-Commit-Position: refs/heads/master@{#13638} TBR=mflodman@webrtc.org,sakal@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6042 Committed: https://crrev.com/41bce13482464741e916190b4e5ec3c628f606dd Cr-Commit-Position: refs/heads/master@{#13640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -52 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 3 chunks +1 line, -51 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
guidou
Created Revert of GN: Create target for video_capture_tests on Linux.
4 years, 4 months ago (2016-08-04 13:48:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2217463002/1
4 years, 4 months ago (2016-08-04 13:48:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 13:48:22 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/41bce13482464741e916190b4e5ec3c628f606dd Cr-Commit-Position: refs/heads/master@{#13640}
4 years, 4 months ago (2016-08-04 13:48:28 UTC) #7
sakal
4 years, 4 months ago (2016-08-04 14:08:43 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2211013002/ by sakal@webrtc.org.

The reason for reverting is: Fix issue..

Powered by Google App Engine
This is Rietveld 408576698