Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/playout_delay_oracle_unittest.cc

Issue 2217383002: Use RtpPacketToSend in RtpSenderVideo (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Ported PlayoutDelay extension support. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 20 matching lines...) Expand all
31 report_blocks_.push_back(report_block); 31 report_blocks_.push_back(report_block);
32 playout_delay_oracle_.OnReceivedRtcpReportBlocks(report_blocks_); 32 playout_delay_oracle_.OnReceivedRtcpReportBlocks(report_blocks_);
33 } 33 }
34 34
35 ReportBlockList report_blocks_; 35 ReportBlockList report_blocks_;
36 PlayoutDelayOracle playout_delay_oracle_; 36 PlayoutDelayOracle playout_delay_oracle_;
37 }; 37 };
38 38
39 TEST_F(PlayoutDelayOracleTest, DisabledByDefault) { 39 TEST_F(PlayoutDelayOracleTest, DisabledByDefault) {
40 EXPECT_FALSE(playout_delay_oracle_.send_playout_delay()); 40 EXPECT_FALSE(playout_delay_oracle_.send_playout_delay());
41 EXPECT_EQ(playout_delay_oracle_.min_playout_delay_ms(), -1); 41 EXPECT_EQ(-1, playout_delay_oracle_.playout_delay().min_ms);
42 EXPECT_EQ(playout_delay_oracle_.max_playout_delay_ms(), -1); 42 EXPECT_EQ(-1, playout_delay_oracle_.playout_delay().max_ms);
43 } 43 }
44 44
45 TEST_F(PlayoutDelayOracleTest, SendPlayoutDelayUntilSeqNumberExceeds) { 45 TEST_F(PlayoutDelayOracleTest, SendPlayoutDelayUntilSeqNumberExceeds) {
46 PlayoutDelay playout_delay = {kMinPlayoutDelay, kMaxPlayoutDelay}; 46 PlayoutDelay playout_delay = {kMinPlayoutDelay, kMaxPlayoutDelay};
47 playout_delay_oracle_.UpdateRequest(kSsrc, playout_delay, kSequenceNumber); 47 playout_delay_oracle_.UpdateRequest(kSsrc, playout_delay, kSequenceNumber);
48 EXPECT_TRUE(playout_delay_oracle_.send_playout_delay()); 48 EXPECT_TRUE(playout_delay_oracle_.send_playout_delay());
49 EXPECT_EQ(playout_delay_oracle_.min_playout_delay_ms(), kMinPlayoutDelay); 49 EXPECT_EQ(kMinPlayoutDelay, playout_delay_oracle_.playout_delay().min_ms);
50 EXPECT_EQ(playout_delay_oracle_.max_playout_delay_ms(), kMaxPlayoutDelay); 50 EXPECT_EQ(kMaxPlayoutDelay, playout_delay_oracle_.playout_delay().max_ms);
51 51
52 // Oracle indicates playout delay should be sent if highest sequence number 52 // Oracle indicates playout delay should be sent if highest sequence number
53 // acked is lower than the sequence number of the first packet containing 53 // acked is lower than the sequence number of the first packet containing
54 // playout delay. 54 // playout delay.
55 ReportRTCPFeedback(kSsrc, kSequenceNumber - 1); 55 ReportRTCPFeedback(kSsrc, kSequenceNumber - 1);
56 EXPECT_TRUE(playout_delay_oracle_.send_playout_delay()); 56 EXPECT_TRUE(playout_delay_oracle_.send_playout_delay());
57 57
58 // An invalid ssrc feedback report is dropped by the oracle. 58 // An invalid ssrc feedback report is dropped by the oracle.
59 ReportRTCPFeedback(kSsrc + 1, kSequenceNumber + 1); 59 ReportRTCPFeedback(kSsrc + 1, kSequenceNumber + 1);
60 EXPECT_TRUE(playout_delay_oracle_.send_playout_delay()); 60 EXPECT_TRUE(playout_delay_oracle_.send_playout_delay());
61 61
62 // Oracle indicates playout delay should not be sent if sequence number 62 // Oracle indicates playout delay should not be sent if sequence number
63 // acked on a matching ssrc indicates the receiver has received the playout 63 // acked on a matching ssrc indicates the receiver has received the playout
64 // delay values. 64 // delay values.
65 ReportRTCPFeedback(kSsrc, kSequenceNumber + 1); 65 ReportRTCPFeedback(kSsrc, kSequenceNumber + 1);
66 EXPECT_FALSE(playout_delay_oracle_.send_playout_delay()); 66 EXPECT_FALSE(playout_delay_oracle_.send_playout_delay());
67 } 67 }
68 68
69 } // namespace webrtc 69 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/playout_delay_oracle.cc ('k') | webrtc/modules/rtp_rtcp/source/producer_fec.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698