Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2216533002: Move RTP for synchroninzation and rename classes, files and variables. (Closed)

Created:
4 years, 4 months ago by mflodman
Modified:
4 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move RTP for synchroninzation and rename classes, files and variables. This CL removes (almost) the last RTP references in VideoReceiveStream. There are still references to RTPFragmentationHeader and SSRCs, which will be dealt with later. There are also new GUARDED_BY and thred checker added to the synchronization class. When there are othre transports than RTP, there will instead be an interface + inheritance for RtpStreamReceiver and RtpStreamSynchronizattion in VideoReceiveStream. This work will be done when we actually know how we want to make thee transport interface. BUG=webrtc:5838 Committed: https://crrev.com/4cd2790f170028b2864b7fa66d5e7400631b4273 Cr-Commit-Position: refs/heads/master@{#13655}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Indentation + rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -386 lines) Patch
M webrtc/video/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/video/rtp_streams_synchronizer.h View 1 chunk +73 lines, -0 lines 0 comments Download
A + webrtc/video/rtp_streams_synchronizer.cc View 1 5 chunks +52 lines, -49 lines 0 comments Download
M webrtc/video/stream_synchronization.h View 3 chunks +8 lines, -4 lines 0 comments Download
M webrtc/video/stream_synchronization.cc View 4 chunks +30 lines, -52 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 3 chunks +3 lines, -1 line 0 comments Download
M webrtc/video/video_receive_stream.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M webrtc/video/video_stream_decoder.h View 2 chunks +0 lines, -2 lines 0 comments Download
D webrtc/video/vie_sync_module.h View 1 chunk +0 lines, -71 lines 0 comments Download
D webrtc/video/vie_sync_module.cc View 1 chunk +0 lines, -194 lines 0 comments Download
M webrtc/video/webrtc_video.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mflodman
Åsa, Would you mind taking a look at this CL? https://codereview.webrtc.org/2216533002/diff/1/webrtc/video/rtp_streams_synchronizer.h File webrtc/video/rtp_streams_synchronizer.h (right): https://codereview.webrtc.org/2216533002/diff/1/webrtc/video/rtp_streams_synchronizer.h#newcode35 ...
4 years, 4 months ago (2016-08-04 08:24:05 UTC) #2
åsapersson
lgtm https://codereview.webrtc.org/2216533002/diff/1/webrtc/video/rtp_streams_synchronizer.cc File webrtc/video/rtp_streams_synchronizer.cc (right): https://codereview.webrtc.org/2216533002/diff/1/webrtc/video/rtp_streams_synchronizer.cc#newcode92 webrtc/video/rtp_streams_synchronizer.cc:92: voe_channel_id_)); nit: check indentation
4 years, 4 months ago (2016-08-05 09:11:47 UTC) #3
mflodman
https://codereview.webrtc.org/2216533002/diff/1/webrtc/video/rtp_streams_synchronizer.cc File webrtc/video/rtp_streams_synchronizer.cc (right): https://codereview.webrtc.org/2216533002/diff/1/webrtc/video/rtp_streams_synchronizer.cc#newcode92 webrtc/video/rtp_streams_synchronizer.cc:92: voe_channel_id_)); On 2016/08/05 09:11:47, åsapersson wrote: > nit: check ...
4 years, 4 months ago (2016-08-05 12:33:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2216533002/20001
4 years, 4 months ago (2016-08-05 12:33:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 13:28:50 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 13:29:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4cd2790f170028b2864b7fa66d5e7400631b4273
Cr-Commit-Position: refs/heads/master@{#13655}

Powered by Google App Engine
This is Rietveld 408576698