Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2216423002: Add gn target for audio_device_tests. (Closed)

Created:
4 years, 4 months ago by Max Morin WebRTC
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add gn target for audio_device_tests. Note (for myself) that this depends on https://codereview.webrtc.org/2219653004/ and https://codereview.webrtc.org/2214003002/, it should not be landed before them. NOTRY=True BUG=webrtc:6170, webrtc:5949 Committed: https://crrev.com/6910537458829b6326db690031ff2759bc72d6f8 Cr-Commit-Position: refs/heads/master@{#13773}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M .gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
kjellander_webrtc
lgtm assuming dependent CLs are fixed. Bonus points for adding to check_targets in .gn - ...
4 years, 4 months ago (2016-08-09 21:28:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2216423002/20001
4 years, 4 months ago (2016-08-16 08:02:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15488)
4 years, 4 months ago (2016-08-16 08:39:52 UTC) #8
kjellander_webrtc
On 2016/08/16 08:39:52, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-08-16 08:57:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2216423002/40001
4 years, 4 months ago (2016-08-16 09:10:10 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-16 09:17:47 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 09:17:54 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6910537458829b6326db690031ff2759bc72d6f8
Cr-Commit-Position: refs/heads/master@{#13773}

Powered by Google App Engine
This is Rietveld 408576698