Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2214113002: Fix case-sensitive build system errors. (Closed)

Created:
4 years, 4 months ago by tkchin_webrtc
Modified:
4 years, 4 months ago
CC:
niklas.enbom, peah-webrtc, qiang.lu, tterriberry_mozilla.com, webrtc-reviews_webrtc.org, yujie_mao (webrtc)
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix case-sensitive build system errors. This is https://codereview.webrtc.org/2141093002/, just wanted to get it in. NOTRY=True BUG= Committed: https://crrev.com/33f00e1272cdc4cfd9d434290bf0a96745e5741c Cr-Commit-Position: refs/heads/master@{#13649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -182 lines) Patch
M webrtc/build/ios/build_ios_libs.sh View 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/RTCICECandidate+JSON.h View 1 chunk +0 lines, -22 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/RTCICECandidate+JSON.m View 1 chunk +0 lines, -100 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/RTCICEServer+JSON.h View 1 chunk +0 lines, -19 lines 0 comments Download
D webrtc/examples/objc/AppRTCDemo/RTCICEServer+JSON.m View 1 chunk +0 lines, -43 lines 0 comments Download
A + webrtc/examples/objc/AppRTCDemo/RTCIceCandidate+JSON.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCDemo/RTCIceCandidate+JSON.m View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCDemo/RTCIceServer+JSON.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/examples/objc/AppRTCDemo/RTCIceServer+JSON.m View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
tkchin_webrtc
4 years, 4 months ago (2016-08-04 18:42:23 UTC) #3
kjellander_webrtc
I'd guess the trybot have issues with the case-sensitivity as well. Maybe the original CL ...
4 years, 4 months ago (2016-08-04 19:31:38 UTC) #4
tkchin_webrtc
On 2016/08/04 19:31:38, kjellander_webrtc wrote: > I'd guess the trybot have issues with the case-sensitivity ...
4 years, 4 months ago (2016-08-04 19:38:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2214113002/1
4 years, 4 months ago (2016-08-04 19:40:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 19:46:50 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/33f00e1272cdc4cfd9d434290bf0a96745e5741c Cr-Commit-Position: refs/heads/master@{#13649}
4 years, 4 months ago (2016-08-04 19:47:00 UTC) #12
jacek.marchwicki
4 years, 4 months ago (2016-08-11 11:48:02 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698