Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2211413003: GN: Add targets for AppRTCDemo on Mac+iOS (Closed)

Created:
4 years, 4 months ago by tkchin_webrtc
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Add targets for AppRTCDemo on Mac+iOS BUG=webrtc:6022 NOTRY=True Committed: https://crrev.com/2ddfdba989df8e6ba767cfe856ba5c97cff527f7 Cr-Commit-Position: refs/heads/master@{#13666}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -13 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/examples/BUILD.gn View 2 chunks +265 lines, -2 lines 0 comments Download
M webrtc/examples/objc/AppRTCDemo/ios/ARDMainView.m View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/examples/objc/AppRTCDemo/mac/APPRTCViewController.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/objc/AppRTCDemo/mac/APPRTCViewController.m View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/examples/objc/AppRTCDemo/mac/main.m View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tkchin_webrtc
seems like libvpx has configuration issues in its BUILD.gn This will not build for iOS32 ...
4 years, 4 months ago (2016-08-05 22:55:47 UTC) #3
kjellander_webrtc
On 2016/08/05 22:55:47, tkchin_webrtc wrote: > seems like libvpx has configuration issues in its BUILD.gn ...
4 years, 4 months ago (2016-08-08 04:30:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2211413003/1
4 years, 4 months ago (2016-08-08 04:33:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 04:37:50 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 04:38:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ddfdba989df8e6ba767cfe856ba5c97cff527f7
Cr-Commit-Position: refs/heads/master@{#13666}

Powered by Google App Engine
This is Rietveld 408576698