Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2211013002: Reland of GN: Create target for video_capture_tests on Linux. (Closed)

Created:
4 years, 4 months ago by sakal
Modified:
4 years, 4 months ago
Reviewers:
mflodman, guidou
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhengzhonghou_agora.io, tterriberry_mozilla.com, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of GN: Create target for video_capture_tests on Linux. (patchset #1 id:1 of https://codereview.webrtc.org/2217463002/ ) Reason for revert: Fix issue. Original issue's description: > Revert of GN: Create target for video_capture_tests on Linux. (patchset #2 id:20001 of https://codereview.webrtc.org/2207463004/ ) > > Reason for revert: > Breaks bots. > See https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder%20%28dbg%29/builds/15490 > > Original issue's description: > > GN: Create target for video_capture_tests on Linux. > > > > BUG=webrtc:6042 > > > > Committed: https://crrev.com/171c7fef0a8b7a1598ac87e0349e210372cb974c > > Cr-Commit-Position: refs/heads/master@{#13638} > > TBR=mflodman@webrtc.org,sakal@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6042 > > Committed: https://crrev.com/41bce13482464741e916190b4e5ec3c628f606dd > Cr-Commit-Position: refs/heads/master@{#13640} TBR=mflodman@webrtc.org,guidou@webrtc.org BUG=webrtc:6042 Committed: https://crrev.com/06bfe1f8795bf1cb1f367475c8c634df2606cef7 Cr-Commit-Position: refs/heads/master@{#13641}

Patch Set 1 #

Patch Set 2 : Replace absolute path with a relative one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M webrtc/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 1 3 chunks +51 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
sakal
Created Reland of GN: Create target for video_capture_tests on Linux.
4 years, 4 months ago (2016-08-04 14:08:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2211013002/70001
4 years, 4 months ago (2016-08-04 14:12:44 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 4 months ago (2016-08-04 14:54:08 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 14:54:20 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06bfe1f8795bf1cb1f367475c8c634df2606cef7
Cr-Commit-Position: refs/heads/master@{#13641}

Powered by Google App Engine
This is Rietveld 408576698