DescriptionRevert of Enable socketservers unittests on windows (patchset #7 id:260001 of https://codereview.webrtc.org/2199193004/ )
Reason for revert:
Win64 Debug seems to be broken because of this CL.
https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug
The Win32SocketTest.TestGetSetOptionsIPv4 test is failing with
[ RUN ] Win32SocketTest.TestGetSetOptionsIPv4
(win32socketserver.cc:299): GetRemoteAddress: unable to get remote addr, socket=672
(winping.cc:262): IcmpSendEcho(, 65507): 0
Full logs at
https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug/builds/8444/steps/webrtc_nonparallel_tests/logs/stdio
I filed a bug at https://bugs.chromium.org/p/webrtc/issues/detail?id=6178
Original issue's description:
> Enable socketservers unittests on windows.
> failing tests disabling moved to ifdefs within the test files from build files.
>
> R=tommi@webrtc.org
>
> Committed: https://crrev.com/e51e11910faddb00921a8bb274f0d9374d55011f
> Cr-Commit-Position: refs/heads/master@{#13623}
TBR=tommi@webrtc.org,danilchap@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Committed: https://crrev.com/9f1771b7290bc432e4225c9eef02ff7532ae2c75
Cr-Commit-Position: refs/heads/master@{#13642}
Patch Set 1 #
Messages
Total messages: 9 (5 generated)
|