Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2209333002: Revert of Enable socketservers unittests on windows (Closed)

Created:
4 years, 4 months ago by ehmaldonado_webrtc
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enable socketservers unittests on windows (patchset #7 id:260001 of https://codereview.webrtc.org/2199193004/ ) Reason for revert: Win64 Debug seems to be broken because of this CL. https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug The Win32SocketTest.TestGetSetOptionsIPv4 test is failing with [ RUN ] Win32SocketTest.TestGetSetOptionsIPv4 (win32socketserver.cc:299): GetRemoteAddress: unable to get remote addr, socket=672 (winping.cc:262): IcmpSendEcho(, 65507): 0 Full logs at https://build.chromium.org/p/client.webrtc/builders/Win64%20Debug/builds/8444/steps/webrtc_nonparallel_tests/logs/stdio I filed a bug at https://bugs.chromium.org/p/webrtc/issues/detail?id=6178 Original issue's description: > Enable socketservers unittests on windows. > failing tests disabling moved to ifdefs within the test files from build files. > > R=tommi@webrtc.org > > Committed: https://crrev.com/e51e11910faddb00921a8bb274f0d9374d55011f > Cr-Commit-Position: refs/heads/master@{#13623} TBR=tommi@webrtc.org,danilchap@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/9f1771b7290bc432e4225c9eef02ff7532ae2c75 Cr-Commit-Position: refs/heads/master@{#13642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -38 lines) Patch
M webrtc/BUILD.gn View 2 chunks +11 lines, -4 lines 0 comments Download
M webrtc/base/physicalsocketserver_unittest.cc View 2 chunks +3 lines, -21 lines 0 comments Download
M webrtc/base/socket_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/socket_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M webrtc/base/win32socketserver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ehmaldonado_webrtc
Created Revert of Enable socketservers unittests on windows
4 years, 4 months ago (2016-08-04 14:49:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2209333002/1
4 years, 4 months ago (2016-08-04 14:49:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 16:18:16 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 16:18:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f1771b7290bc432e4225c9eef02ff7532ae2c75
Cr-Commit-Position: refs/heads/master@{#13642}

Powered by Google App Engine
This is Rietveld 408576698