Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2207463004: GN: Create target for video_capture_tests on Linux. (Closed)

Created:
4 years, 4 months ago by sakal
Modified:
4 years, 4 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), zhengzhonghou_agora.io, tterriberry_mozilla.com, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Create target for video_capture_tests on Linux. BUG=webrtc:6042 Committed: https://crrev.com/171c7fef0a8b7a1598ac87e0349e210372cb974c Cr-Commit-Position: refs/heads/master@{#13638}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes according to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M webrtc/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 1 3 chunks +51 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
sakal
Magnus, PTAL.
4 years, 4 months ago (2016-08-03 14:28:27 UTC) #5
mflodman
One comment, then LGTM. https://codereview.webrtc.org/2207463004/diff/1/webrtc/modules/video_capture/BUILD.gn File webrtc/modules/video_capture/BUILD.gn (right): https://codereview.webrtc.org/2207463004/diff/1/webrtc/modules/video_capture/BUILD.gn#newcode169 webrtc/modules/video_capture/BUILD.gn:169: if (is_linux) { I thikn ...
4 years, 4 months ago (2016-08-04 09:51:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2207463004/20001
4 years, 4 months ago (2016-08-04 12:35:15 UTC) #11
sakal
https://codereview.webrtc.org/2207463004/diff/1/webrtc/modules/video_capture/BUILD.gn File webrtc/modules/video_capture/BUILD.gn (right): https://codereview.webrtc.org/2207463004/diff/1/webrtc/modules/video_capture/BUILD.gn#newcode169 webrtc/modules/video_capture/BUILD.gn:169: if (is_linux) { On 2016/08/04 09:51:04, mflodman_OOO wrote: > ...
4 years, 4 months ago (2016-08-04 12:35:59 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 13:29:29 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/171c7fef0a8b7a1598ac87e0349e210372cb974c Cr-Commit-Position: refs/heads/master@{#13638}
4 years, 4 months ago (2016-08-04 13:29:36 UTC) #16
guidou
4 years, 4 months ago (2016-08-04 13:48:08 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2217463002/ by guidou@webrtc.org.

The reason for reverting is: Breaks bots. 
See
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder%2....

Powered by Google App Engine
This is Rietveld 408576698