Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 2206583002: Add UMA for tracking which BWE versions are in use. (Closed)

Created:
4 years, 4 months ago by stefan-webrtc
Modified:
4 years, 4 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add UMA for tracking which BWE versions are in use. NOTRY=true BUG=webrtc:6156 Committed: https://crrev.com/64636dda43adac60bebb63e3a7d1cb3602d7d845 Cr-Commit-Position: refs/heads/master@{#13619}

Patch Set 1 #

Patch Set 2 : Also include no extension at all. #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -11 lines) Patch
M webrtc/modules/congestion_controller/delay_based_bwe.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 3 chunks +8 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + webrtc/modules/remote_bitrate_estimator/bwe_defines.cc View 1 2 3 1 chunk +1 line, -7 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/bwe_defines.h View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 3 chunks +8 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 1 3 chunks +11 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (10 generated)
stefan-webrtc
4 years, 4 months ago (2016-08-02 14:53:44 UTC) #2
stefan-webrtc
Also include no extension at all.
4 years, 4 months ago (2016-08-02 14:57:52 UTC) #3
terelius
lgtm
4 years, 4 months ago (2016-08-02 15:14:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2206583002/20001
4 years, 4 months ago (2016-08-02 15:27:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/9795) android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 4 months ago (2016-08-02 15:30:17 UTC) #8
stefan-webrtc
.
4 years, 4 months ago (2016-08-02 15:32:04 UTC) #9
stefan-webrtc
.
4 years, 4 months ago (2016-08-02 15:38:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2206583002/60001
4 years, 4 months ago (2016-08-02 15:39:22 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/9797)
4 years, 4 months ago (2016-08-02 15:49:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2206583002/60001
4 years, 4 months ago (2016-08-03 07:27:30 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-03 07:29:08 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 07:29:18 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/64636dda43adac60bebb63e3a7d1cb3602d7d845
Cr-Commit-Position: refs/heads/master@{#13619}

Powered by Google App Engine
This is Rietveld 408576698