Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2206473003: Remove LooperExecutor and replace it with built-in HandlerThread. (Closed)

Created:
4 years, 4 months ago by sakal
Modified:
4 years, 4 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove LooperExecutor and replace it with built-in HandlerThread. Committed: https://crrev.com/5d4d59c069628396548ce36c5b7c4d95fba34a5b Cr-Commit-Position: refs/heads/master@{#13688}

Patch Set 1 #

Patch Set 2 : Remove unused includes. #

Patch Set 3 : Completely remove LooperExecutor. #

Patch Set 4 : Rebase. #

Total comments: 2

Patch Set 5 : Changes according to magjed's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -292 lines) Patch
M webrtc/examples/BUILD.gn View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketChannelClient.java View 1 2 8 chunks +11 lines, -11 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java View 1 2 3 4 11 chunks +17 lines, -15 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/util/LooperExecutor.java View 1 2 1 chunk +0 lines, -140 lines 0 comments Download
D webrtc/examples/androidjunit/src/org/appspot/apprtc/util/LooperExecutorTest.java View 1 2 3 1 chunk +0 lines, -122 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
sakal
Magnus, PTAL when you get back from vacation.
4 years, 4 months ago (2016-08-02 09:07:35 UTC) #2
magjed_webrtc
https://codereview.webrtc.org/2206473003/diff/60001/webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java File webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java (right): https://codereview.webrtc.org/2206473003/diff/60001/webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java#newcode92 webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java:92: handlerThread.quitSafely(); quitSafely was added in API level 18 so ...
4 years, 4 months ago (2016-08-08 09:37:31 UTC) #8
sakal
https://codereview.webrtc.org/2206473003/diff/60001/webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java File webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java (right): https://codereview.webrtc.org/2206473003/diff/60001/webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java#newcode92 webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java:92: handlerThread.quitSafely(); On 2016/08/08 09:37:31, magjed_webrtc wrote: > quitSafely was ...
4 years, 4 months ago (2016-08-08 09:52:52 UTC) #9
magjed_webrtc
lgtm
4 years, 4 months ago (2016-08-08 12:01:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2206473003/80001
4 years, 4 months ago (2016-08-08 12:02:55 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_clang_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/builds/4162)
4 years, 4 months ago (2016-08-08 12:15:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2206473003/80001
4 years, 4 months ago (2016-08-09 08:58:05 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-09 09:03:44 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 09:03:45 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5d4d59c069628396548ce36c5b7c4d95fba34a5b
Cr-Commit-Position: refs/heads/master@{#13688}

Powered by Google App Engine
This is Rietveld 408576698