webrtc/media/engine/webrtcvoiceengine.h - Issue 2206223002: Removed calls to VoE::SetPlayout() from WebRTCVoiceEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvoiceengine.h

Issue 2206223002: Removed calls to VoE::SetPlayout() from WebRTCVoiceEngine. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Added most tests back. Changed fake VoE. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/media/engine/fakewebrtcvoiceengine.h ('K') | « webrtc/media/engine/fakewebrtcvoiceengine.h ('k') | webrtc/media/engine/webrtcvoiceengine.cc » ('j') | webrtc/media/engine/webrtcvoiceengine_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/media/engine/webrtcvoiceengine.h

diff --git a/webrtc/media/engine/webrtcvoiceengine.h b/webrtc/media/engine/webrtcvoiceengine.h

index 64e0f5b1850d9860b23c69751c2f2883ebc7dfec..ec7eb95e9a6e48553c991f3d2f4b04e9bc69a7d6 100644

--- a/webrtc/media/engine/webrtcvoiceengine.h

+++ b/webrtc/media/engine/webrtcvoiceengine.h

@@ -177,9 +177,7 @@ class WebRtcVoiceMediaChannel final : public VoiceMediaChannel,

uint32_t ssrc,

const webrtc::RtpParameters& parameters) override;

- bool SetPlayout(bool playout) override;

- bool PausePlayout();

- bool ResumePlayout();

+ void SetPlayout(bool playout) override;

void SetSend(bool send) override;

bool SetAudioSend(uint32_t ssrc,

bool enable,

@@ -245,8 +243,7 @@ class WebRtcVoiceMediaChannel final : public VoiceMediaChannel,

WebRtcVoiceEngine* engine() { return engine_; }

int GetLastEngineError() { return engine()->GetLastEngineError(); }

int GetOutputLevel(int channel);

- bool SetPlayout(int channel, bool playout);

- bool ChangePlayout(bool playout);

+ void ChangePlayout(bool playout);

int CreateVoEChannel();

bool DeleteVoEChannel(int channel);

bool IsDefaultRecvStream(uint32_t ssrc) {