webrtc/media/base/mediachannel.h - Issue 2206223002: Removed calls to VoE::SetPlayout() from WebRTCVoiceEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/base/mediachannel.h

Issue 2206223002: Removed calls to VoE::SetPlayout() from WebRTCVoiceEngine. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Added most tests back. Changed fake VoE. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/base/mediachannel.h

diff --git a/webrtc/media/base/mediachannel.h b/webrtc/media/base/mediachannel.h

index 5a4124ac11f70cf93ff39b9dc8fe73d7d6e10c6b..1355b36679012475ba39e118484f80b07c81a0a3 100644

--- a/webrtc/media/base/mediachannel.h

+++ b/webrtc/media/base/mediachannel.h

@@ -908,7 +908,7 @@ class VoiceMediaChannel : public MediaChannel {

uint32_t ssrc,

const webrtc::RtpParameters& parameters) = 0;

// Starts or stops playout of received audio.

- virtual bool SetPlayout(bool playout) = 0;

+ virtual void SetPlayout(bool playout) = 0;

// Starts or stops sending (and potentially capture) of local audio.

virtual void SetSend(bool send) = 0;

// Configure stream for sending.

« no previous file with comments | « webrtc/media/base/fakemediaengine.h ('k') | webrtc/media/engine/fakewebrtccall.h » ('j') | webrtc/media/engine/fakewebrtcvoiceengine.h » ('J')