Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2205803002: Add plot of network delay change computed based on transport feedback. (Closed)

Created:
4 years, 4 months ago by stefan-webrtc
Modified:
4 years, 4 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add plot of network delay change computed based on transport feedback. NOTRY=true Committed: https://crrev.com/c3de0333c0a262c0aacfbb33c286ff5ace781abf Cr-Commit-Position: refs/heads/master@{#13610}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -6 lines) Patch
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/transport_feedback_adapter.cc View 2 chunks +7 lines, -1 line 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 2 4 chunks +93 lines, -5 lines 0 comments Download
M webrtc/tools/event_log_visualizer/generate_timeseries.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
stefan-webrtc
4 years, 4 months ago (2016-08-02 08:44:03 UTC) #2
terelius
https://codereview.webrtc.org/2205803002/diff/20001/webrtc/tools/event_log_visualizer/analyzer.cc File webrtc/tools/event_log_visualizer/analyzer.cc (right): https://codereview.webrtc.org/2205803002/diff/20001/webrtc/tools/event_log_visualizer/analyzer.cc#newcode847 webrtc/tools/event_log_visualizer/analyzer.cc:847: clock.AdvanceTimeMilliseconds(rtcp_iterator->first / 1000 - What's the purpose of this ...
4 years, 4 months ago (2016-08-02 09:01:33 UTC) #3
stefan-webrtc
https://codereview.webrtc.org/2205803002/diff/20001/webrtc/tools/event_log_visualizer/analyzer.cc File webrtc/tools/event_log_visualizer/analyzer.cc (right): https://codereview.webrtc.org/2205803002/diff/20001/webrtc/tools/event_log_visualizer/analyzer.cc#newcode847 webrtc/tools/event_log_visualizer/analyzer.cc:847: clock.AdvanceTimeMilliseconds(rtcp_iterator->first / 1000 - On 2016/08/02 09:01:33, terelius wrote: ...
4 years, 4 months ago (2016-08-02 09:28:11 UTC) #4
terelius
lgtm
4 years, 4 months ago (2016-08-02 10:51:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2205803002/40001
4 years, 4 months ago (2016-08-02 10:53:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/9780)
4 years, 4 months ago (2016-08-02 12:57:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2205803002/40001
4 years, 4 months ago (2016-08-02 14:20:40 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-02 14:22:22 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 14:22:30 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c3de0333c0a262c0aacfbb33c286ff5ace781abf
Cr-Commit-Position: refs/heads/master@{#13610}

Powered by Google App Engine
This is Rietveld 408576698