Remove StartSSLWithServer from SSLStreamAdapter.

Remove StartSSLWithServer from SSLStreamAdapter.

It's not used by anything any more. We only use SSLStreamAdapter in
the mode where it verifies the peer's certificate using a signaled
digest.

R=pthatcher@webrtc.org, zhihuang@webrtc.org

Committed: https://crrev.com/c8762a838f6d21377ef8fa2e4642b464e3347545
Cr-Commit-Position: refs/heads/master@{#13730}

[Taylor Brandstetter, 2016-08-02 20:27:45]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2016-08-02 20:27:45]

Peter, please take a look. Also, I'm only adding 1 reviewer since this CL is so
small, but you can add a 2nd if you prefer.

https://codereview.webrtc.org/2204883004/diff/1/webrtc/base/opensslstreamadap...
File webrtc/base/opensslstreamadapter.cc (right):

https://codereview.webrtc.org/2204883004/diff/1/webrtc/base/opensslstreamadap...
webrtc/base/opensslstreamadapter.cc:1084: return true;
I'll modify the logic in this method in the other CL I've been working on. In
this CL, I *only* want to remove the unused code path.

[pthatcher1, 2016-08-03 22:24:43]

pthatcher@webrtc.org changed reviewers:
+ zhihuang@webrtc.org

[pthatcher1, 2016-08-03 22:24:43]

lgtm

Zhi, can you also review it?

[Zhi Huang, 2016-08-03 23:25:50]

On 2016/08/03 22:24:43, pthatcher1 wrote:
> lgtm
> 
> Zhi, can you also review it?

lgtm.

[Taylor Brandstetter, 2016-08-09 16:38:39]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-08-09 16:38:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-09 16:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 16:43:54]

Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/13224)

[Taylor Brandstetter, 2016-08-10 17:11:08]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-08-10 17:11:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-10 17:12:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 17:12:29]

Try jobs failed on following builders:
  ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_dbg/builds/1716)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/11752)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/16994)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/15644)

[Taylor Brandstetter, 2016-08-11 16:43:26]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2016-08-11 16:43:26]

The patchset sent to the CQ was uploaded after l-g-t-m from zhihuang@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2204883004/#ps40001 (title:
"Removing unused variable.")

[commit-bot: I haz the power, 2016-08-11 16:43:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-11 18:44:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 18:44:08]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[Taylor Brandstetter, 2016-08-11 19:02:03]

Description was changed from

==========
Remove StartSSLWithServer from SSLStreamAdapter.

It's not used by anything any more. We only use SSLStreamAdapter in
the mode where it verifies the peer's certificate using a signaled
digest.
==========

to

==========
Remove StartSSLWithServer from SSLStreamAdapter.

It's not used by anything any more. We only use SSLStreamAdapter in
the mode where it verifies the peer's certificate using a signaled
digest.

R=pthatcher@webrtc.org, zhihuang@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c8762a838f6d21377ef8fa2e4...
==========

[Taylor Brandstetter, 2016-08-11 19:02:04]

Committed patchset #3 (id:40001) manually as
c8762a838f6d21377ef8fa2e4642b464e3347545 (presubmit successful).

[commit-bot: I haz the power, 2016-08-11 19:02:05]

Description was changed from

==========
Remove StartSSLWithServer from SSLStreamAdapter.

It's not used by anything any more. We only use SSLStreamAdapter in
the mode where it verifies the peer's certificate using a signaled
digest.

R=pthatcher@webrtc.org, zhihuang@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c8762a838f6d21377ef8fa2e4...
==========

to

==========
Remove StartSSLWithServer from SSLStreamAdapter.

It's not used by anything any more. We only use SSLStreamAdapter in
the mode where it verifies the peer's certificate using a signaled
digest.

R=pthatcher@webrtc.org, zhihuang@webrtc.org

Committed: https://crrev.com/c8762a838f6d21377ef8fa2e4642b464e3347545
Cr-Commit-Position: refs/heads/master@{#13730}
==========