Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: webrtc/build/ios/build_ios_libs.sh

Issue 2204783002: Don't build VP9 for iOS framework. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/build/ios/build_ios_libs.sh
diff --git a/webrtc/build/ios/build_ios_libs.sh b/webrtc/build/ios/build_ios_libs.sh
index 772fc6824e487b4e62c6ce71ce5b64f2c7088d93..c368715254c8065237c87161f04e4e0fa5db24ca 100755
--- a/webrtc/build/ios/build_ios_libs.sh
+++ b/webrtc/build/ios/build_ios_libs.sh
@@ -51,6 +51,7 @@ function build_webrtc {
local flavor=$2
local target_arch=$3
local build_type=$4
+ local libvpx_build_vp9=$5
local ninja_output_dir=${base_output_dir}/${target_arch}_ninja
local library_output_dir=${base_output_dir}/${target_arch}_libs
@@ -86,7 +87,8 @@ function build_webrtc {
export GYP_DEFINES="OS=ios target_arch=${target_arch} use_objc_h264=1 \
clang_xcode=1 ios_deployment_target=8.0 \
-ios_override_visibility=${override_visibility}"
+ios_override_visibility=${override_visibility} \
+libvpx_build_vp9=${libvpx_build_vp9}"
export GYP_GENERATORS="ninja"
export GYP_GENERATOR_FLAGS="output_dir=${ninja_output_dir}"
@@ -146,6 +148,9 @@ BUILD_TYPE="framework"
PERFORM_CLEAN=0
FLAVOR="Profile"
POINT_VERSION="0"
+# TODO(tkchin): Add ability to pass in a flag to build vp9. Odds are mobile
+# clients will not want it though because of the higher CPU usage.
+LIBVPX_BUILD_VP9=0
# Parse arguments.
while getopts "hb:co:r:" opt; do
@@ -172,7 +177,7 @@ ARCHS=( "arm" "arm64" "ia32" "x64" )
for ARCH in "${ARCHS[@]}"
do
echo "Building WebRTC arch: ${ARCH}"
- build_webrtc ${OUTPUT_DIR} ${FLAVOR} $ARCH ${BUILD_TYPE}
+ build_webrtc ${OUTPUT_DIR} ${FLAVOR} $ARCH ${BUILD_TYPE} ${LIBVPX_BUILD_VP9}
done
ARM_NINJA_DIR=${OUTPUT_DIR}/arm_ninja/${FLAVOR}-iphoneos
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698