Chromium Code Reviews

Issue 2203363002: Remove a few meaningless TODOs (Closed)

Created:
4 years, 4 months ago by mflodman
Modified:
4 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, perkj_webrtc, sdk-team_agora.io
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+1 line, -5 lines)
M webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit_objc.mm View 1 chunk +0 lines, -1 line 0 comments
M webrtc/test/fake_network_pipe.h View 1 chunk +0 lines, -1 line 1 comment
M webrtc/test/video_renderer.cc View 1 chunk +1 line, -3 lines 0 comments

Messages

Total messages: 7 (3 generated)
mflodman
Åsa, Please take a look at this CL just removing TODOs and changing one NULL ...
4 years, 4 months ago (2016-08-03 12:56:55 UTC) #2
åsapersson
lgtm
4 years, 4 months ago (2016-08-03 13:11:09 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/997684079e1beb15ae2e768893c5897a3667a662 Cr-Commit-Position: refs/heads/master@{#13624}
4 years, 4 months ago (2016-08-03 13:38:26 UTC) #6
mflodman
4 years, 4 months ago (2016-08-03 13:38:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
997684079e1beb15ae2e768893c5897a3667a662 (presubmit successful).

Powered by Google App Engine